Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Focused improvement] [Manifest] Fix duplicate enum definition #996

Merged
merged 1 commit into from
Apr 20, 2022
Merged

[Focused improvement] [Manifest] Fix duplicate enum definition #996

merged 1 commit into from
Apr 20, 2022

Conversation

sc-nikolaoslazaridis
Copy link
Contributor

@sc-nikolaoslazaridis sc-nikolaoslazaridis commented Apr 20, 2022 •
edited by illiakovalenko
Loading

Description / Motivation

  1. Deleted fieldTypes.ts file in packages/sitecore-jss-dev-tools/src/manifest/generator/fieldTypes.ts
  2. Removed fieldTypes import in packages/sitecore-jss-dev-tools/src/manifest/generator/manifest.ts
  3. Removed fieldTypes from the return of createManifestInstance function

Refactoring. Remove unused files/objects.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-nikolaoslazaridis sc-nikolaoslazaridis requested a review from a team April 20, 2022 09:45
@illiakovalenko illiakovalenko changed the title [Focused improvement] Investigate (& ideally fix) duplicate enum definition [Focused improvement] [Manifest] Fix duplicate enum definition Apr 20, 2022
@illiakovalenko illiakovalenko merged commit f9fe33f into Sitecore:dev Apr 20, 2022
@sc-nikolaoslazaridis sc-nikolaoslazaridis deleted the bugfix/446956-Fix-duplicate-enum-definitions branch May 9, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-nikolaoslazaridis @illiakovalenko