Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAV] Support .env file #999

Merged
merged 6 commits into from
May 2, 2022
Merged

[RAV] Support .env file #999

merged 6 commits into from
May 2, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Apr 27, 2022

Description / Motivation

  • Added .env file support
  • Each bootstrap command uses dotenv, in order to have access to environment variables if running any command without jss command
  • Whenever it's possible use constants
  • Whenever it's possible use temp config file, as it has access to environment variables and to the values from package.json
  • Removed @sitecore-jss/sitecore-jss package from angular sample, as we should use sitecore-jss-angular
  • Use both graphql and rest services in order to have ability to switch fetch method
  • Dynamically enable debug logging for react and vue samples, as they have different environment variables naming convention

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team April 27, 2022 12:29
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, see just a few comments

@illiakovalenko illiakovalenko requested a review from ambrauer May 2, 2022 11:29
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit 3dabcdd into dev May 2, 2022
@ambrauer ambrauer deleted the feature/527441 branch May 2, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants