Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#38 Updated versioned fields in an item are not published #39

Merged
merged 2 commits into from
Sep 8, 2020
Merged

#38 Updated versioned fields in an item are not published #39

merged 2 commits into from
Sep 8, 2020

Conversation

zaheer-tariq
Copy link

Fix for the issue reported here #38

@zaheer-tariq zaheer-tariq mentioned this pull request Sep 8, 2020
Closed
@cassidydotdk
Copy link
Member

My knee-jerk reaction was; "this can't be it". But re-reading this code, I can't think of a single reason I would force commitEdit to false in a finally clause here. A catch, sure. Not a finally.

Good catch. Pun intended ;-)

@cassidydotdk cassidydotdk changed the base branch from master to develop September 8, 2020 07:06
@cassidydotdk cassidydotdk merged commit 71dfdf8 into SitecoreUnicorn:develop Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaheer-tariq @cassidydotdk @muhz