Merge branch 'main' into style-cleanup

Siteimprove · Nov 23, 2023 · 7bf734e · 7bf734e
2 parents 6c448c8 + 321a7eb
commit 7bf734e
Show file tree

Hide file tree

Showing 500 changed files with 8,186 additions and 7,676 deletions.
diff --git a/.changeset/beige-birds-taste.md b/.changeset/beige-birds-taste.md
diff --git a/.changeset/bright-gorillas-travel.md b/.changeset/bright-gorillas-travel.md
diff --git a/.changeset/dry-peaches-draw.md b/.changeset/dry-peaches-draw.md
diff --git a/.changeset/gentle-maps-march.md b/.changeset/gentle-maps-march.md
diff --git a/.changeset/green-days-fly.md b/.changeset/green-days-fly.md
diff --git a/.changeset/happy-gorillas-flash.md b/.changeset/happy-gorillas-flash.md
diff --git a/.changeset/lemon-rabbits-appear.md b/.changeset/lemon-rabbits-appear.md
@@ -0,0 +1,7 @@
+---
+"@siteimprove/alfa-selector": minor
+---
+
+**Breaking:** The type guards on selectors are now under the namespace of the same name.
+
+That is, use `Compound.isCompound` instead of `Selector.isCompound`, …
diff --git a/.changeset/long-plums-join.md b/.changeset/long-plums-join.md
diff --git a/.changeset/metal-pandas-end.md b/.changeset/metal-pandas-end.md
@@ -0,0 +1,7 @@
+---
+"@siteimprove/alfa-selector": minor
+---
+
+**Breaking:** `Compound` selectors are now built on top of Iterable, rather than re-inventing chained lists.
+
+That is, `Compound#left` and `Compound#right` are no more available, but `Compound.selectors` replaces them.
diff --git a/.changeset/moody-kings-nail.md b/.changeset/moody-kings-nail.md
@@ -0,0 +1,7 @@
+---
+"@siteimprove/alfa-selector": minor
+---
+
+**Breaking:** The various kinds of selectors are now directly exported from the package, out of the `Selector` namespace.
+
+That is, use `Id` instead of `Selector.Id`, … (or `import * as Selector` and keep using `Selector.Id`).
diff --git a/.changeset/sharp-apricots-explain.md b/.changeset/sharp-apricots-explain.md
diff --git a/.changeset/shiny-worms-push.md b/.changeset/shiny-worms-push.md
diff --git a/.changeset/strange-hairs-share.md b/.changeset/strange-hairs-share.md
diff --git a/.changeset/thin-melons-hope.md b/.changeset/thin-melons-hope.md
diff --git a/.changeset/tidy-cars-own.md b/.changeset/tidy-cars-own.md
@@ -0,0 +1,7 @@
+---
+"@siteimprove/alfa-css": minor
+---
+
+**Added:** `Function.parse` now also accepts a `Thunk` as body parser.
+
+This notably allows to build recursive parsers by wrapping them in continuation.
diff --git a/.changeset/twenty-seahorses-try.md b/.changeset/twenty-seahorses-try.md
@@ -0,0 +1,7 @@
+---
+"@siteimprove/alfa-selector": minor
+---
+
+**Breaking:** `List` selectors are now built on top of Iterable, rather than re-inventing chained lists.
+
+That is, `List#left` and `List#right` are no more available, but `List.selectors` replaces them.
diff --git a/.github/workflows/alfa-release.yml b/.github/workflows/alfa-release.yml
@@ -143,6 +143,7 @@ jobs:
       - name: Make npm release
         run: >
           yarn workspaces foreach
+          --all
           --no-private
           --topological-dev
           npm publish --tolerate-republish

diff --git a/.github/workflows/pr-commands.yml b/.github/workflows/pr-commands.yml
@@ -10,11 +10,6 @@ on:
   issue_comment:
     types: [created]
 
-permissions:
-  contents: write
-  pull-requests: write
-  repository-projects: write
-
 jobs:
   pull-request-command:
     runs-on: ubuntu-latest
@@ -24,7 +19,7 @@ jobs:
         uses: siteimprove/pr-command/check-run/check@v2.4
         with:
           # Personal access token (PAT) used to fetch the repository and add reaction on comment.
-          token: ${{ secrets.A11Y_PUBLIC_GITHUB_TOKEN }}
+          token: ${{ secrets.TEST_TOKEN }}
 
       # The repository has been checked out by PR commands!
 
@@ -43,4 +38,4 @@ jobs:
         uses: siteimprove/pr-command/check-run/run@v2.4
         with:
           # Personal access token (PAT) used to fetch the repository and add reaction on comment.
-          token: ${{ secrets.A11Y_PUBLIC_GITHUB_TOKEN }}
+          token: ${{ secrets.TEST_TOKEN }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -19,4 +19,4 @@ jobs:
       user-email: 8577410+siteimprove-builduser@users.noreply.github.com
       generate-documentation: true
     secrets:
-      token: ${{ secrets.A11Y_PUBLIC_GITHUB_TOKEN }}
+      token: ${{ secrets.TEST_TOKEN }}
diff --git a/.yarn/releases/yarn-4.0.1.cjs → .yarn/releases/yarn-4.0.2.cjs b/.yarn/releases/yarn-4.0.1.cjs → .yarn/releases/yarn-4.0.2.cjs
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -4,4 +4,4 @@ npmScopes:
   siteimprove:
     npmRegistryServer: "https://npm.pkg.github.com"
 
-yarnPath: .yarn/releases/yarn-4.0.1.cjs
+yarnPath: .yarn/releases/yarn-4.0.2.cjs
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,45 @@
 # Alfa changelog
 
+## [0.69.0](../../compare/v0.68.0...v0.69.0) (2023-11-21)
+
+### Breaking
+
+- [@siteimprove/alfa-style](packages/alfa-style/CHANGELOG.md#0690): The `hasInlineStyleProperty` and `hasCascadedValueDeclaredInInlineStyleOf` predicates have been removed.
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): Various `Value.partiallyResolve()` functions have been removed.
+
+- [@siteimprove/alfa-rules](packages/alfa-rules/CHANGELOG.md#0690): Diagnostics `WithPreviousHeading` and `WithNextHeading` have been replaced by `WithOtherHeading`.
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): The various `Value.parseBase` functions are no more available.
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): `Angle#resolve()` does not require a resolver anymore, since 100% is always 1 full turn.
+
+- [@siteimprove/alfa-rules](packages/alfa-rules/CHANGELOG.md#0690): Question `visible-focus-classes`, and question type `string[]` have been removed.
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): CSS `Value` types no longer accept a `CALC` parameter; it is automatically inferred.
+
+### Added
+
+- [@siteimprove/alfa-rules](packages/alfa-rules/CHANGELOG.md#0690): Accessible name is now recorded in the diagnostics for R15, R39, R41 and R81.
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): `Value` now expose a `partiallyResolve()` instance method.
+
+- [@siteimprove/alfa-rules](packages/alfa-rules/CHANGELOG.md#0690): Role is now recorded in the diagnostic for R8.
+
+- [@siteimprove/alfa-dom](packages/alfa-dom/CHANGELOG.md#0690), [@siteimprove/alfa-tree](packages/alfa-tree/CHANGELOG.md#0690): Tree `Node`, and DOM `Node` can now have an `externalId` (`string`) and some `extraData` (`any`).
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): `Percentage` can now be partially resolved into fixed `Percentage`.
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): a `AnglePercentage.resolve()` helper is now available to handle `Percentage` shenanigans.
+
+- [@siteimprove/alfa-css](packages/alfa-css/CHANGELOG.md#0690): `Percentage` builders now accept an optional type hint indicating into what the percentage resolves.
+
+### Fixed
+
+- [@siteimprove/alfa-rules](packages/alfa-rules/CHANGELOG.md#0690): SIA-R70 ow accepts `<hgroup>`.
+
+- [@siteimprove/alfa-aria](packages/alfa-aria/CHANGELOG.md#0690): The `<hgroup>` element now has an implicit role of `group`.
+
 ## [0.68.0](../../compare/v0.67.0...v0.68.0) (2023-10-20)
 
 ### Breaking

diff --git a/docs/api/alfa-css.angle.calculated.md b/docs/api/alfa-css.angle.calculated.md
@@ -8,7 +8,7 @@
 **Signature:**
 
 ```typescript
-export namespace Calculated 
+namespace Calculated 
 ```
 
 ## Interfaces

diff --git a/docs/api/alfa-css.angle.canonical.md b/docs/api/alfa-css.angle.canonical.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export type Canonical = Fixed<"deg">;
+type Canonical = Fixed<"deg">;
 ```
 **References:** [Fixed](./alfa-css.angle.fixed.md)
 
diff --git a/docs/api/alfa-css.angle.fixed.md b/docs/api/alfa-css.angle.fixed.md
@@ -8,7 +8,7 @@
 **Signature:**
 
 ```typescript
-export namespace Fixed 
+namespace Fixed 
 ```
 
 ## Interfaces

diff --git a/docs/api/alfa-css.angle.iangle.hascalculation.md b/docs/api/alfa-css.angle.iangle.hascalculation.md
diff --git a/docs/api/alfa-css.angle.iangle.md b/docs/api/alfa-css.angle.iangle.md
diff --git a/docs/api/alfa-css.angle.iangle.resolve.md b/docs/api/alfa-css.angle.iangle.resolve.md
diff --git a/docs/api/alfa-css.angle.isangle.md b/docs/api/alfa-css.angle.isangle.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export function isAngle(value: unknown): value is Angle;
+function isAngle(value: unknown): value is Angle;
 ```
 
 ## Parameters

diff --git a/docs/api/alfa-css.angle.iscalculated.md b/docs/api/alfa-css.angle.iscalculated.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export function isCalculated(value: unknown): value is Calculated;
+function isCalculated(value: unknown): value is Calculated;
 ```
 
 ## Parameters

diff --git a/docs/api/alfa-css.angle.isfixed.md b/docs/api/alfa-css.angle.isfixed.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export function isFixed(value: unknown): value is Fixed;
+function isFixed(value: unknown): value is Fixed;
 ```
 
 ## Parameters

diff --git a/docs/api/alfa-css.angle.json.md b/docs/api/alfa-css.angle.json.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export type JSON = Calculated.JSON | Fixed.JSON;
+type JSON = Calculated.JSON | Fixed.JSON;
 ```
 **References:** [Calculated.JSON](./alfa-css.angle.calculated.json.md)<!-- -->, [Fixed.JSON](./alfa-css.angle.fixed.json.md)
 
diff --git a/docs/api/alfa-css.angle.of.md b/docs/api/alfa-css.angle.of.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export function of<U extends Unit.Angle>(value: number, unit: U): Fixed<U>;
+function of<U extends Unit.Angle>(value: number, unit: U): Fixed<U>;
 ```
 
 ## Parameters

diff --git a/docs/api/alfa-css.angle.of_1.md b/docs/api/alfa-css.angle.of_1.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export function of<U extends Unit.Angle>(value: BaseAngle<U>): Fixed<U>;
+function of<U extends Unit.Angle>(value: BaseAngle<U>): Fixed<U>;
 ```
 
 ## Parameters

diff --git a/docs/api/alfa-css.angle.of_2.md b/docs/api/alfa-css.angle.of_2.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export function of(value: Math<"angle">): Calculated;
+function of(value: Math<"angle">): Calculated;
 ```
 
 ## Parameters

diff --git a/docs/api/alfa-css.angle.resolver.md b/docs/api/alfa-css.angle.resolver.md
@@ -7,5 +7,5 @@
 **Signature:**
 
 ```typescript
-export type Resolver = {};
+type Resolver = {};
 ```
diff --git a/docs/api/alfa-css.anglepercentage.calculated.md b/docs/api/alfa-css.anglepercentage.calculated.md
@@ -7,7 +7,7 @@
 **Signature:**
 
 ```typescript
-export namespace Calculated 
+namespace Calculated 
 ```
 
 ## Interfaces

diff --git a/docs/api/alfa-css.anglepercentage.calculated.resolve.md b/docs/api/alfa-css.anglepercentage.calculated.resolve.md
@@ -7,15 +7,8 @@
 **Signature:**
 
 ```typescript
-resolve(resolver: Resolver): Canonical;
+resolve(): Canonical;
 ```
-
-## Parameters
-
-|  Parameter | Type | Description |
-|  --- | --- | --- |
-|  resolver | [Resolver](./alfa-css.anglepercentage.resolver.md) |  |
-
 **Returns:**
 
 [Canonical](./alfa-css.anglepercentage.canonical.md)