Remove unused question (#1497)

* Remove unused question * Extract documentation
Siteimprove · Nov 14, 2023 · 908585a · 908585a
1 parent 20bcc36
commit 908585a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/.changeset/strange-hairs-share.md b/.changeset/strange-hairs-share.md
@@ -0,0 +1,5 @@
+---
+"@siteimprove/alfa-rules": minor
+---
+
+**Breaking:** Question `visible-focus-classes`, and question type `string[]` have been removed.
diff --git a/docs/review/api/alfa-rules.api.md b/docs/review/api/alfa-rules.api.md
@@ -180,8 +180,6 @@ export namespace Question {
         // (undocumented)
         "node[]": Iterable<Node>;
         // (undocumented)
-        "string[]": Iterable<string>;
-        // (undocumented)
         boolean: boolean;
         // (undocumented)
         node: Option<Node>;
@@ -272,10 +270,6 @@ export namespace Question {
             readonly type: "boolean";
             readonly message: "Do these [role] landmarks have the same or equivalent content?";
         };
-        readonly "visible-focus-classes": {
-            readonly type: "string[]";
-            readonly message: "Which classes have a visible focus indicator?";
-        };
         readonly "has-focus-indicator": {
             readonly type: "boolean";
             readonly message: "Does the element have a visible focus indicator?";

diff --git a/packages/alfa-rules/src/common/act/question.ts b/packages/alfa-rules/src/common/act/question.ts
@@ -17,7 +17,6 @@ export namespace Question {
     "node[]": Iterable<Node>;
     "color[]": Iterable<RGB>;
     string: string;
-    "string[]": Iterable<string>;
   }
 
   type TypeName<U extends Uri> = Data[U]["type"];
@@ -188,10 +187,6 @@ export namespace Question {
       message: `Do these [role] landmarks have the same or equivalent content?`,
     },
     // R65
-    "visible-focus-classes": {
-      type: "string[]",
-      message: `Which classes have a visible focus indicator?`,
-    },
     "has-focus-indicator": {
       type: "boolean",
       message: `Does the element have a visible focus indicator?`,

diff --git a/packages/alfa-rules/test/common/oracle.ts b/packages/alfa-rules/test/common/oracle.ts
@@ -54,9 +54,6 @@ export function oracle<I, T extends Hashable, S>(
 
       case "string":
         return wrapper(question, answers[question.uri]!);
-
-      case "string[]":
-        return wrapper(question, answers[question.uri]!);
     }
   };
 }