Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIA-R65: Provide classes and number of matches in diagnostic #1164

Merged
merged 15 commits into from
Jul 8, 2022
Merged

SIA-R65: Provide classes and number of matches in diagnostic #1164

merged 15 commits into from
Jul 8, 2022

Conversation

zsofitoth
Copy link

@zsofitoth zsofitoth commented Jun 20, 2022 •
edited
Loading

Resolves #1161

@zsofitoth zsofitoth added the minor Backwards-compatible change that touches public API label Jun 20, 2022
@zsofitoth zsofitoth requested a review from a team June 20, 2022 15:27
@zsofitoth zsofitoth self-assigned this Jun 20, 2022
@zsofitoth zsofitoth requested a review from Jym77 June 20, 2022 15:27
@zsofitoth zsofitoth marked this pull request as draft June 20, 2022 15:27
Jym77
Jym77 requested changes Jun 21, 2022
View reviewed changes
packages/alfa-rules/src/sia-er65/diagnostics.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-er65/diagnostics.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-er65/diagnostics.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-er65/rule.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 changed the title SIA-ER65: Split result to show why we pass SIA-R65: Split result to show why we pass Jul 5, 2022
@zsofitoth zsofitoth marked this pull request as ready for review July 7, 2022 07:25
@zsofitoth zsofitoth requested a review from Jym77 July 7, 2022 07:25
@zsofitoth zsofitoth changed the title SIA-R65: Split result to show why we pass SIA-R65: Provide classes and number of matches in diagnostic Jul 7, 2022
Jym77
Jym77 requested changes Jul 7, 2022
View reviewed changes
packages/alfa-rules/src/sia-r65/diagnostics.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r65/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r65/rule.ts Outdated Show resolved Hide resolved
@zsofitoth zsofitoth requested a review from Jym77 July 7, 2022 12:12
Jym77
Jym77 requested changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small polish.

packages/alfa-rules/src/sia-r65/diagnostics.ts Show resolved Hide resolved
packages/alfa-rules/src/sia-r65/diagnostics.ts Show resolved Hide resolved
packages/alfa-rules/test/sia-r65/rule.spec.tsx Outdated Show resolved Hide resolved
Zsofia Toth added 3 commits July 7, 2022 16:08
Polish code
8c71498
Merge branch 'zto/SIA-ER65-split-result-to-show-reason-for-passing' o…
f80f6d1 
…f github.com:Siteimprove/alfa into zto/SIA-ER65-split-result-to-show-reason-for-passing
Cleanup
3620ad5
@zsofitoth zsofitoth requested a review from Jym77 July 7, 2022 14:11
Jym77
Jym77 previously approved these changes Jul 7, 2022
View reviewed changes
@zsofitoth zsofitoth requested a review from Jym77 July 7, 2022 14:29
Jym77
Jym77 previously approved these changes Jul 8, 2022
View reviewed changes
@zsofitoth zsofitoth requested a review from Jym77 July 8, 2022 08:17
@zsofitoth zsofitoth enabled auto-merge (squash) July 8, 2022 08:18
@zsofitoth zsofitoth merged commit 377153e into main Jul 8, 2022
@zsofitoth zsofitoth deleted the zto/SIA-ER65-split-result-to-show-reason-for-passing branch July 8, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 approved these changes

Assignees

@zsofitoth zsofitoth

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIA-R65: provide classes and number of matches in diagnostic
2 participants
@zsofitoth @Jym77