Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy support of calc expressions #1201

Merged
merged 25 commits into from
Aug 2, 2022
Merged

Easy support of calc expressions #1201

merged 25 commits into from
Aug 2, 2022

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jul 22, 2022

Resolves #980

Add infrastructure for easy support of calc() expressions.
Also streamlining and modernising the type hierarchy for Numeric.

Effectively adding support in all other properties should be taken separately.

@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Jul 22, 2022
@Jym77 Jym77 self-assigned this Jul 22, 2022
@Jym77 Jym77 changed the title Calc expressions Easy support of calc expressions Jul 25, 2022
@Jym77
Copy link
Contributor Author

Jym77 commented Jul 28, 2022

API extractor is unhappy about the variance indication that is needed here (it's a TS 4.7 syntax): microsoft/rushstack#3486 (comment)

Building a similar hack to circumvent it and wait until fix 😖 as the previous time.

@Jym77 Jym77 added major Backwards-incompatible change that touches public API and removed minor Backwards-compatible change that touches public API labels Jul 28, 2022
@Jym77 Jym77 marked this pull request as ready for review July 28, 2022 12:27
@Jym77 Jym77 requested review from a team and elenamongelli July 28, 2022 12:27
Copy link
Contributor

@elenamongelli elenamongelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jym77 Jym77 merged commit 85001f5 into main Aug 2, 2022
@Jym77 Jym77 deleted the calc-expressions branch August 2, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support calc expressions in more CSS properties.
2 participants