Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support calculation in outline-* #1219

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Support calculation in outline-* #1219

merged 6 commits into from
Sep 13, 2022

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Sep 6, 2022

Part of #1202 which has caused problem in DEV-13509.

@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Sep 6, 2022
@Jym77 Jym77 self-assigned this Sep 6, 2022
@Jym77 Jym77 marked this pull request as ready for review September 6, 2022 13:43
@Jym77 Jym77 requested review from a team and elenamongelli September 6, 2022 13:43
elenamongelli
elenamongelli approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@elenamongelli elenamongelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/alfa-style/test/property/outline.spec.tsx Show resolved Hide resolved
@Jym77 Jym77 merged commit 56d995d into main Sep 13, 2022
@Jym77 Jym77 deleted the outline-calc-support branch September 13, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenamongelli elenamongelli elenamongelli approved these changes

Assignees

@Jym77 Jym77

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @elenamongelli