Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline definitions of style properties #1431

Merged
merged 20 commits into from
Jun 13, 2023
Merged

Streamline definitions of style properties #1431

merged 20 commits into from
Jun 13, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jun 12, 2023 •
edited
Loading

Part of #1202

  • Fix bug in text-shadow not accepting list of shadows.
  • Fix bug in background-position-x/y not accepting keyword values.
  • Hoist most parser of existing complex CSS value type to their value definition in alfa-css.
  • Introduce Longhand.fromKeywords and use it as much as possible.
  • Rework a bit what longhand are exposing for convenience.

@Jym77 Jym77 self-assigned this Jun 12, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Jun 12, 2023
@Jym77 Jym77 changed the title Length use calculated length in styles Streamline definitions of style properties Jun 12, 2023
@Jym77 Jym77 marked this pull request as ready for review June 12, 2023 12:55
@Jym77 Jym77 requested review from a team and rcj-siteimprove June 12, 2023 12:55
@Jym77
Copy link
Contributor Author

Jym77 commented Jun 12, 2023

!pr extract

rcj-siteimprove
rcj-siteimprove approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one non-blocking question.

packages/alfa-css/src/value/collection/list.ts Show resolved Hide resolved
@Jym77 Jym77 added this pull request to the merge queue Jun 13, 2023
Merged via the queue into main with commit 5cc9bc9 Jun 13, 2023
@Jym77 Jym77 deleted the length-use-calculated-length-in-styles branch June 13, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove