Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce calculatable numeric types #1432

Merged
merged 34 commits into from
Jun 21, 2023
Merged

Introduce calculatable numeric types #1432

merged 34 commits into from
Jun 21, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jun 15, 2023 •
edited
Loading

Part of #1202

  • Duplicate all Numeric sub-types into calculatable versions.
  • Use calculatable numeric in style properties.
  • Keep fixed numeric in more complex types (color, shadow, …)
  • Assorted clean up.
  • Automatically infer dimension's type kind (Unit,Length, …) and canonical unit (px, …) from the type representation ("length", …)
  • Introduce a Foo.Canonical abstraction; ultimately all CSS types should have it and the other intermediate abstractions (Calculated, Fixed) should probably be hidden away.

Jym77 added 21 commits June 13, 2023 09:35
@Jym77
Add calculalted Numeric abstraction
045a646
@Jym77
Add calculated Number type
2c33caa
@Jym77
Add some Number tests
ab1a14d
@Jym77
Typo
c92e5fb
@Jym77
Scaffold for calculated interger
af24dcc
@Jym77
Merge branch 'main' into calculated-numeric-types
d79f623
@Jym77
Accept broader refinements in Selective.if()
40b2cee
@Jym77
Replace CSS Number by (fixed) calculatable ones
9203fa5
@Jym77
Clean up parser
76f0fef
@Jym77
Use (fixed) calculated Integers
547dee5
@Jym77
Remove and infer redundant second parameter of dimensions
cc11701
@Jym77
Make calculatable length inherits from calculatable dimensions
1f1ccf6
@Jym77
Add some angle parsing tests
f134f99
@Jym77
Build calculatable Angle abstraction
5f9a477
@Jym77
Spread usage of calculatable Angles
8629c7c
@Jym77
Streamline expressions reducing
ebb2e7e
@Jym77
Introduce calculatable percentage abstraction
f168e47
@Jym77
Remove NumberPercentage
6c91bfa
@Jym77
Use calculatable percentages
555894f
@Jym77
Streamline percentage resolusion
7cf970b
@Jym77
Clean up
58f1bf7
@Jym77
Copy link
Contributor Author

Jym77 commented Jun 15, 2023

!pr extract

@Jym77 Jym77 changed the title Calculated numeric types Introduce calculatable numeric types Jun 15, 2023
@Jym77 Jym77 self-assigned this Jun 15, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Jun 15, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Jun 15, 2023

!pr extract

@Jym77
Copy link
Contributor Author

Jym77 commented Jun 15, 2023

!pr extract

@Jym77
Copy link
Contributor Author

Jym77 commented Jun 15, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review June 15, 2023 14:29
@Jym77 Jym77 requested review from a team and rcj-siteimprove June 15, 2023 14:29
@Jym77
Copy link
Contributor Author

Jym77 commented Jun 16, 2023

!pr extract

rcj-siteimprove
rcj-siteimprove previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just found one typo in a changeset

.changeset/hip-baboons-applaud.md Outdated Show resolved Hide resolved
@Jym77 @rcj-siteimprove
Typo
b5feffa 
Co-authored-by: Rolf Christian Jørgensen <114920418+rcj-siteimprove@users.noreply.github.com>
@Jym77 Jym77 enabled auto-merge June 21, 2023 11:50
@Jym77 Jym77 added this pull request to the merge queue Jun 21, 2023
Merged via the queue into main with commit f4cda0e Jun 21, 2023
@Jym77 Jym77 deleted the calculated-numeric-types branch June 21, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove