Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculatable Position #1454

Merged
merged 36 commits into from
Oct 3, 2023
Merged

Calculatable Position #1454

merged 36 commits into from
Oct 3, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jul 17, 2023

Part of #1202

@Jym77 Jym77 changed the title Calculatable position Calculatable Position Jul 17, 2023
@Jym77 Jym77 self-assigned this Jul 17, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Jul 17, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Jul 17, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review July 18, 2023 07:22
@Jym77 Jym77 requested a review from a team July 18, 2023 07:22
@Jym77
Copy link
Contributor Author

Jym77 commented Jul 18, 2023

!pr extract

@Jym77
Copy link
Contributor Author

Jym77 commented Jul 18, 2023

!pr extract

@Jym77 Jym77 marked this pull request as draft July 19, 2023 12:10
@Jym77 Jym77 marked this pull request as ready for review July 20, 2023 07:41
@Jym77 Jym77 marked this pull request as draft July 20, 2023 12:56
Jym77 and others added 4 commits August 9, 2023 15:31
* Typo

* Add some package implementation details

* Streamline code

* Streamline parser

* Clean up test indentation

* Add some shadow teest

* Eport Option interface

* Add more shadow parsing tests

* Add a resolve test

* Make Shadow calculatable

* Add changesets

* Extract API

* Typos

* Clean up

* Actually accept calculations

* Add Value.hasCalculation helper

* Rename parameter

* Extract API

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Streamline parsers

* Clean up

* Share parsers in tests

* Add Matrix parsing tests

* Simplify Matrix parser

* Improve parseIf

* Improve parser

* Add tests for Rotate prasing

* Add tests for Rotate prasing

* Simplify parser

* Simplify parser

* Add Scale parsing tests

* Simplify Scale parser

* Simplify parsers

* Add Skew parsing tests

* Simplify Skew parsers

* Add Translate tests

* Simplify parsers

* Clean up

* Extract API

* Typos

* Make translate Function calculatable

* Make matrix calculatable

* Make matrix calculatable

* Streamline Perspective

* Make Perspective calculatable

* Make Rotate calculatable

* Add calculated rotate tests

* Add calculated rotate tests

* Make Scale calculatable

* Accept calculation in Skew

* Make Translate calculatable

* Accept calculation in all transform function

* Clean up

* Extract API

* Clean up

* Extract API

* Fix type inferrence

* Extract API

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Add breaking test

* Improve documentation

* Correctly search for id in the full tree

* Update documentation

* Add changeset
@Jym77 Jym77 marked this pull request as ready for review October 3, 2023 13:46
@Jym77 Jym77 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 5f0f911 Oct 3, 2023
6 checks passed
@Jym77 Jym77 deleted the calculatable-position branch October 3, 2023 13:57
@Jym77 Jym77 mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Backwards-incompatible change that touches public API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants