Make arguments of Native
functions optional
#1678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes them more flexible, notably for script injection:
inject(fromWindow)
serialisesfromWindow
correctly but doesn't pass an argument.inject(fromWindow, window)
requires to have a handle (living in nodeJS world) on the window (living in the injection world), this is usually possible for DOM nodes, but not always for thewindow
object itself.inject( () => fromWindow(window) )
does not "recursively" serialisefromWindow
which thus does not exists in the injection world. It would require using a bundler, or pre-injecting the function, … None of these being very convenient.Now,
inject(fromWindow)
will work, defaulting toglobalThis.window
which is the most frequent case. If another window is needed, it can still be passed around (but then need to be provided by the caller).