Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate AWS cache options and normalize implementations #219

Merged
merged 3 commits into from
Feb 6, 2022

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

While the options types share the same properties, it's important to maintain separate options classes to allow further extensibility and simplify json configuration.

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #219 (c480a6f) into master (376c0e6) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #219   +/-   ##
=====================================
  Coverage      87%    87%           
=====================================
  Files          70     71    +1     
  Lines        1826   1831    +5     
  Branches      269    269           
=====================================
+ Hits         1589   1594    +5     
  Misses        167    167           
  Partials       70     70           
Flag Coverage Δ
unittests 87% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...geSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs 18% <ø> (ø)
....AWS/Providers/AWSS3StorageImageProviderOptions.cs 100% <ø> (ø)
...ders.Azure/Caching/AzureBlobStorageCacheOptions.cs 100% <ø> (ø)
.../Providers/AzureBlobStorageImageProviderOptions.cs 100% <ø> (ø)
...arp.Web.Providers.AWS/Caching/AWSS3StorageCache.cs 87% <100%> (ø)
....Providers.AWS/Caching/AWSS3StorageCacheOptions.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376c0e6...c480a6f. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit d3a834f into master Feb 6, 2022
@JimBobSquarePants JimBobSquarePants deleted the js/aws-options branch February 6, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant