Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseAccelerateEndpoint to IAWSS3BucketClientOptions #276

Conversation

mdupras
Copy link
Contributor

@mdupras mdupras commented Jun 20, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I've simply added UseAccelerateEndpoint in the IAWSS3BucketClientOptions and use it where it's applicable.
The feature must be enable on the bucket to use it.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #276 (d7227c3) into main (92a3b3b) will increase coverage by 0%.
The diff coverage is 0%.

❗ Current head d7227c3 differs from pull request most recent head 5940f95. Consider uploading reports for the commit 5940f95 to get more accurate results

@@         Coverage Diff         @@
##           main   #276   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        75     75           
  Lines      2041   2033    -8     
  Branches    298    296    -2     
===================================
- Hits       1741   1735    -6     
  Misses      215    215           
+ Partials     85     83    -2     
Flag Coverage Δ
unittests 85% <0%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...geSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs 15% <0%> (-3%) ⬇️
....Providers.AWS/Caching/AWSS3StorageCacheOptions.cs 83% <0%> (-17%) ⬇️
....AWS/Providers/AWSS3StorageImageProviderOptions.cs 85% <0%> (-15%) ⬇️
.../Synchronization/RefCountedConcurrentDictionary.cs 72% <0%> (-4%) ⬇️
...geSharp.Web/Providers/FileProviderImageProvider.cs 78% <0%> (ø)
src/ImageSharp.Web/CaseHandlingUriBuilder.cs 76% <0%> (+11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5fab7...5940f95. Read the comment docs.

@JimBobSquarePants
Copy link
Member

@mdupras Thanks for this. I'll have a look ASAP 👍

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help here; this all looks good to me. It's shame we can't test it using s3rver.

@JimBobSquarePants JimBobSquarePants merged commit e10c8a0 into SixLabors:main Jul 2, 2022
@mdupras mdupras deleted the feature/2161-aws-use-accelerated-endpoint branch March 15, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants