Remove nullabel disable #307
Conversation
First batch of removing nullable disable
|
Attention this targets the v3 branch |
|
|
||
| if (converter != null) | ||
| { | ||
| return ((ICommandConverter<T>)converter).ConvertFrom( | ||
| _ = ((ICommandConverter<T>)converter).TryConvertFrom( |
There was a problem hiding this comment.
Shouldn't a null parsedValue be a false return?
It's been years since I've looked at this code.
There was a problem hiding this comment.
here we just handle it a few lines later with a null check. Didn't want to change everything
| { | ||
| if (string.IsNullOrWhiteSpace(value)) | ||
| { | ||
| return Array.Empty<T>(); | ||
| convertedValue = Array.Empty<T>(); |
There was a problem hiding this comment.
Ah.... OK. So in some cases we do and some we don't.
This should be more consistant and return false on empty input.
There was a problem hiding this comment.
yeah and in some cases we convert to an struct so there is no null..
There was a problem hiding this comment.
I'm gonna pull this down and have a play.
JimBobSquarePants
force-pushed
the
stefannikolei/nullable/remove_nullable-disable
branch
from
65ecc76
to
5b6086d
Compare
…kolei/nullable/remove_nullable-disable
…s://github.com/stefannikolei/ImageSharp.Web into stefannikolei/nullable/remove_nullable-disable
|
I set you on a wild goose chase there sorry! This all looks great. Thanks! 👍 |
All good 😅 I left you one file with #nullable enable for you in the main project |
Prerequisites
Description
Removes the first nullable disable from the code base