Remove nullable disable from aws

[stefannikolei]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
• I have provided test coverage for my change (where applicable)

Description

[codecov]

Codecov Report

Merging #312 (bbf7f47) into main (e13e8af) will decrease coverage by 1%.
The diff coverage is 73%.

@@         Coverage Diff         @@
##           main   #312   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        77     77           
  Lines      2195   2199    +4     
  Branches    309    313    +4     
===================================
  Hits       1873   1873           
  Misses      233    233           
- Partials     89     93    +4     

Flag	Coverage Δ
unittests	85% <73%> (-1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...geSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs	31% <ø> (ø)
...oviders.AWS/Resolvers/AWSS3StorageCacheResolver.cs	100% <ø> (ø)
...oviders.AWS/Providers/AWSS3StorageImageProvider.cs	58% <14%> (-9%)	⬇️
...arp.Web.Providers.AWS/Caching/AWSS3StorageCache.cs	78% <100%> (ø)
....Providers.AWS/Caching/AWSS3StorageCacheOptions.cs	85% <100%> (ø)
....AWS/Providers/AWSS3StorageImageProviderOptions.cs	87% <100%> (ø)
...oviders.AWS/Resolvers/AWSS3StorageImageResolver.cs	92% <100%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[JimBobSquarePants]

We should do a guard check for the bucket name and make this non-nullable.

[stefannikolei]

It is non nullable. But to achieve this we have the ugly hack with = null! in the options :(

[JimBobSquarePants]

Perhaps we should switch to get; init; for our options types to avoid these kinds of hacks. (We're .NET 6)

[stefannikolei]

That makes no difference. Init does not mean that he must set it. It just says that it can not be changed after constructing.

For your desired behavior we need the required keyword and that is net7...

[JimBobSquarePants]

Yeah, you're right (we keep having this conversation 🤣)

I do thoink for .NET 6 though, options-types should use this pattern to enforce immutability.

[JimBobSquarePants]

Perfect. Thanks!