Remove async HMAC operations. #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
===================================
Coverage 85% 85%
===================================
Files 83 82 -1
Lines 2371 2336 -35
Branches 347 347
===================================
- Hits 2026 2000 -26
+ Misses 242 233 -9
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tocsoft
approved these changes
Jun 10, 2023
4 tasks
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Dec 8, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [SixLabors.ImageSharp.Web](https://togithub.com/SixLabors/ImageSharp.Web) | `3.0.1` -> `3.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>SixLabors/ImageSharp.Web (SixLabors.ImageSharp.Web)</summary> ### [`v3.1.0`](https://togithub.com/SixLabors/ImageSharp.Web/releases/tag/v3.1.0) #### What's Changed - Remove async HMAC operations. by [@​JimBobSquarePants](https://togithub.com/JimBobSquarePants) in [https://github.com/SixLabors/ImageSharp.Web/pull/327](https://togithub.com/SixLabors/ImageSharp.Web/pull/327) - Use HMAC one-shot methods instead of instances by [@​jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) in [https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/SixLabors/ImageSharp.Web/pull/336](https://togithub.com/SixLabors/ImageSharp.Web/pull/336) - 3.1 release compatibility by [@​mdupras](https://togithub.com/mdupras) in [https://github.com/SixLabors/ImageSharp.Web/pull/341](https://togithub.com/SixLabors/ImageSharp.Web/pull/341) - Update Imagesharp by [@​JimBobSquarePants](https://togithub.com/JimBobSquarePants) in [https://github.com/SixLabors/ImageSharp.Web/pull/345](https://togithub.com/SixLabors/ImageSharp.Web/pull/345) #### New Contributors - [@​jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) made their first contribution in [https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330) **Full Changelog**: SixLabors/ImageSharp.Web@v3.0.1...v3.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Dec 9, 2023
…845) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [SixLabors.ImageSharp.Web.Providers.Azure](https://togithub.com/SixLabors/ImageSharp.Web) | `3.0.1` -> `3.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>SixLabors/ImageSharp.Web (SixLabors.ImageSharp.Web.Providers.Azure)</summary> ### [`v3.1.0`](https://togithub.com/SixLabors/ImageSharp.Web/releases/tag/v3.1.0) #### What's Changed - Remove async HMAC operations. by [@​JimBobSquarePants](https://togithub.com/JimBobSquarePants) in [https://github.com/SixLabors/ImageSharp.Web/pull/327](https://togithub.com/SixLabors/ImageSharp.Web/pull/327) - Use HMAC one-shot methods instead of instances by [@​jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) in [https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/SixLabors/ImageSharp.Web/pull/336](https://togithub.com/SixLabors/ImageSharp.Web/pull/336) - 3.1 release compatibility by [@​mdupras](https://togithub.com/mdupras) in [https://github.com/SixLabors/ImageSharp.Web/pull/341](https://togithub.com/SixLabors/ImageSharp.Web/pull/341) - Update Imagesharp by [@​JimBobSquarePants](https://togithub.com/JimBobSquarePants) in [https://github.com/SixLabors/ImageSharp.Web/pull/345](https://togithub.com/SixLabors/ImageSharp.Web/pull/345) #### New Contributors - [@​jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) made their first contribution in [https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330) **Full Changelog**: SixLabors/ImageSharp.Web@v3.0.1...v3.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Removing the extremely performance harming async HMAC generation utilities from both
ImageSharpMiddlewareOptionsandRequestAuthorizationUtilitiesSee umbraco/Umbraco-CMS#14364 for more information.
cc @nikolajlauridsen @bergmania @ronaldbarendse