Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata read datetime to UTC #58

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Fix metadata read datetime to UTC #58

merged 1 commit into from
Feb 4, 2019

Conversation

c1rus
Copy link
Contributor

@c1rus c1rus commented Feb 4, 2019

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Read metadata is returning date in local time. When parsing "o" format specifier, the formatted string should be parsed with DateTimeStyles.RoundtripKind. More info here

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
Copy link
Member

Oh wow! That's a major bug, thanks!

@JimBobSquarePants JimBobSquarePants merged commit d13fb8b into SixLabors:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c1rus @CLAassistant @JimBobSquarePants