c4-006 DoS in market orders due to incorrect params.amount comparison… (

#125) * c4-006 DoS in market orders due to incorrect params.amount comparison with dust limit when amount represents cash * Remove params.amount > credit comparison
SizeCredit · Jul 15, 2024 · 8447c4d · 8447c4d
1 parent 6583a50
commit 8447c4d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/libraries/actions/BuyCreditMarket.sol b/src/libraries/actions/BuyCreditMarket.sol
@@ -88,8 +88,8 @@ library BuyCreditMarket {
         }
 
         // validate amount
-        if (params.amount < state.riskConfig.minimumCreditBorrowAToken) {
-            revert Errors.CREDIT_LOWER_THAN_MINIMUM_CREDIT(params.amount, state.riskConfig.minimumCreditBorrowAToken);
+        if (params.amount == 0) {
+            revert Errors.NULL_AMOUNT();
         }
 
         // validate deadline

diff --git a/src/libraries/actions/SellCreditMarket.sol b/src/libraries/actions/SellCreditMarket.sol
@@ -82,16 +82,11 @@ library SellCreditMarket {
                 );
             }
             tenor = debtPosition.dueDate - block.timestamp; // positive since the credit position is transferrable, so the loan must be ACTIVE
-
-            // validate amount
-            if (params.amount > creditPosition.credit) {
-                revert Errors.NOT_ENOUGH_CREDIT(params.amount, creditPosition.credit);
-            }
         }
 
         // validate amount
-        if (params.amount < state.riskConfig.minimumCreditBorrowAToken) {
-            revert Errors.CREDIT_LOWER_THAN_MINIMUM_CREDIT(params.amount, state.riskConfig.minimumCreditBorrowAToken);
+        if (params.amount == 0) {
+            revert Errors.NULL_AMOUNT();
         }
 
         // validate tenor