Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rebuild C static libs if the desired architecture/platform already exists #82

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions LibWally.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
75B9EE002810F88400E31B4D /* PBXContainerItemProxy */ = {
75683E51293049380014553B /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = FE9CD3A8229C397900345DFA /* Project object */;
proxyType = 1;
Expand Down Expand Up @@ -209,7 +209,7 @@
buildRules = (
);
dependencies = (
75B9EE012810F88400E31B4D /* PBXTargetDependency */,
75683E52293049380014553B /* PBXTargetDependency */,
);
name = LibWally;
productName = LibWally;
Expand Down Expand Up @@ -325,10 +325,10 @@
/* End PBXSourcesBuildPhase section */

/* Begin PBXTargetDependency section */
75B9EE012810F88400E31B4D /* PBXTargetDependency */ = {
75683E52293049380014553B /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 75B9EDFC2810F83700E31B4D /* LibWallyCore */;
targetProxy = 75B9EE002810F88400E31B4D /* PBXContainerItemProxy */;
targetProxy = 75683E51293049380014553B /* PBXContainerItemProxy */;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to touch all these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I don't see a reason why it should change -- let me take a second look here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought maybe a checksum of some sort.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you're right. it's the checksum of the scheme action we define here https://github.com/Sjors/libwally-swift/pull/82/files#diff-a0467817f744b83783e73e607681e81427686debb56a8ba92f697ba854994937R13

since our change works, I will go ahead and delete the pre-build script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I misspoke, it was a checksum of our script, build-libwally.sh. Either way, I just committed 2f7f66f to remove the unneeded pre-build script.

};
FE9CD3BD229C397900345DFA /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
ActionType = "Xcode.IDEStandardExecutionActionsCore.ExecutionActionType.ShellScriptAction">
<ActionContent
title = "Run Script"
scriptText = "# We want to clean the libwally-core static build files for simulator so we can&#10;# build the ones for device.&#10;cd $PROJECT_DIR/CLibWally/libwally-core&#10;make clean&#10;rm -rf &quot;$(pwd)/build&quot;&#10;">
scriptText = "# We want to clean the libwally-core static build files for simulator so we can&#10;# build the ones for device.&#10;# cd $PROJECT_DIR/CLibWally/libwally-core&#10;# make clean&#10;# rm -rf &quot;$(pwd)/build&quot;&#10;">
<EnvironmentBuildable>
<BuildableReference
BuildableIdentifier = "primary"
Expand Down