Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Trial Spawners in Spawner Type expression. #7008

Merged
merged 8 commits into from
Sep 1, 2024
Merged

Add support for Trial Spawners in Spawner Type expression. #7008

merged 8 commits into from
Sep 1, 2024

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Aug 29, 2024 •
edited
Loading

Description

Add support for Trial Spawners in Spawner Type expression.
Also adds a test for the expression.

Target Minecraft Versions: any
Requirements: none
Related Issues: #6856

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.9 Targeting a 2.9.X version release labels Aug 30, 2024
@Asleeepp Asleeepp requested a review from sovdeeth August 30, 2024 01:34
@sovdeeth sovdeeth added up for debate When the decision is yet to be debated on the issue in question and removed up for debate When the decision is yet to be debated on the issue in question labels Aug 30, 2024
@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Aug 31, 2024
APickledWalrus
APickledWalrus approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. This could probably use BaseSpawner instead to remove some of the code repetition, but that can also be done in the rework you were doing

@Moderocky Moderocky merged commit cf1658e into SkriptLang:dev/patch Sep 1, 2024
6 checks passed
@Moderocky Moderocky deleted the patch-trial-spawner-support branch September 1, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Asleeepp @sovdeeth @Moderocky @APickledWalrus