Fix JS load handler. Fix JS run loop sync. Add New Arch flag #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sky
commented
Nov 20, 2024
| @@ -215,25 +226,30 @@ + (void)waitForReactNativeLoadWithCompletionHandler:(void (^)(void))handler | |||
| __block __weak id observer; | |||
| __block __weak id observer2; | |||
|
|
|||
| observer = [[NSNotificationCenter defaultCenter] addObserverForName:@"RCTJavaScriptDidLoadNotification" object:nil queue:nil usingBlock:^(NSNotification * _Nonnull note) { | |||
There was a problem hiding this comment.
Don't see any reason to wait for RCTJavaScriptDidLoadNotification when in any case we will need to wait for RCTContentDidAppearNotification. Also RCTJavaScriptDidLoadNotification is not emitted on RN 0.76 with New Arch.
Sky
commented
Nov 20, 2024
|
|
||
| handler(); | ||
| }]; | ||
| dispatch_async(dispatch_get_main_queue(), ^{ |
There was a problem hiding this comment.
dispatch_async probably can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.