skyapm dotnet support log collecting #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuhaoyang
requested changes
Apr 20, 2022
| .AddLogging(logging => | ||
| { | ||
| logging.AddSkyApmLogger(); | ||
| })); |
There was a problem hiding this comment.
Is it necessary to report logs to Skywalking as the default option?
…for AddPushSkyApmLogger
liuhaoyang
reviewed
Apr 27, 2022
|
Please add a copyright header to all new files |
@liuhaoyang Please consider skywalking-eyes to this repository. |
ElderJames
reviewed
Apr 27, 2022
| @@ -23,5 +23,6 @@ namespace SkyApm.Logging | |||
| public interface ILoggerFactory | |||
| { | |||
| ILogger CreateLogger(Type type); | |||
| SkyApm.Logging.ILogger CreateSkyApmLogger(Type type); | |||
There was a problem hiding this comment.
Suggested change
| SkyApm.Logging.ILogger CreateSkyApmLogger(Type type); | |
| ILogger CreateSkyApmLogger(Type type); |
ElderJames
reviewed
Apr 27, 2022
|
|
||
| public ILogger CreateSkyApmLogger(Type type) | ||
| { | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
Why not implement the method?
ElderJames
reviewed
Apr 27, 2022
ElderJames
reviewed
Apr 27, 2022
| @@ -78,7 +78,6 @@ public SegmentContext CreateEntrySegment(string operationName, ICarrier carrier, | |||
| }; | |||
| segmentContext.References.Add(segmentReference); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I don't think this page needs to be modified
ElderJames
reviewed
Apr 27, 2022
ElderJames
reviewed
Apr 27, 2022
| _entrySegmentContextAccessor = serviceProvider.GetService<IEntrySegmentContextAccessor>(); | ||
| _skyApmLogDispatcher = serviceProvider.GetService<ISkyApmLogDispatcher>(); | ||
| _loggerName = type; | ||
| _pushSkywalking= pushSkywalking; |
There was a problem hiding this comment.
I don't understand what the meaning of this switch is.
There was a problem hiding this comment.
Users can decide whether to push logs to Skywallking
liuhaoyang
approved these changes
May 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
skywalking link tracing log