Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AsyncQueueSkyApmLogDispatcher._offset is not correct exactly in muti threads #515

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix: AsyncQueueSkyApmLogDispatcher._offset is not correct exactly in muti threads #515

merged 1 commit into from
Sep 23, 2022

Conversation

sampsonye
Copy link
Contributor

@sampsonye sampsonye commented Sep 21, 2022 •
edited
Loading

Please answer these questions before submitting pull request

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

@sampsonye sampsonye changed the title fix: remove some code fix: AsyncQueueSkyApmLogDispatcher._offset is not correct exactly in muti threads Sep 21, 2022
@wu-sheng wu-sheng added this to the 2.1.0 milestone Sep 21, 2022
@wu-sheng wu-sheng added the bug Something isn't working label Sep 21, 2022
@liuhaoyang
Copy link
Collaborator

If the offset is not reset in flush, once the offset is larger than the config.QueueSize, no more LogRequest will be processed.

@liuhaoyang
Copy link
Collaborator

I think there should be another better way to handle the reset of offset instead of removing directly

@sampsonye
Copy link
Contributor Author

sampsonye commented Sep 23, 2022 •
edited
Loading

If the offset is not reset in flush, once the offset is larger than the config.QueueSize, no more LogRequest will be processed.

i can not find whenever the offset do not equals theQueueSize

can you show some case than they are not equal?

@liuhaoyang
Copy link
Collaborator

i can not find whenever the offset do not equals theQueueSize

Each time a LogerRequest enters Dispatch, the offset will be incremented AsyncQueueSkyApmLogDispatcher.cs#L64

@liuhaoyang liuhaoyang merged commit 000c990 into SkyAPM:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuhaoyang liuhaoyang liuhaoyang approved these changes

Assignees

@liuhaoyang liuhaoyang

Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sampsonye @liuhaoyang @wu-sheng