Brs cra5 #143
Brs cra5 #143
Conversation
.github/workflows/build-brs.yml
Outdated
| @@ -0,0 +1,50 @@ | |||
| name: Build BRS | |||
There was a problem hiding this comment.
Remove file build-brs.yml, Tao Fang is working on another PR to figure out how to build and test brs on CI
tasks/e2e-installs.sh
Outdated
| @@ -101,11 +101,11 @@ npx create-react-app --version | |||
| # ****************************************************************************** | |||
|
|
|||
| cd "$temp_app_path" | |||
| npx create-react-app test-app-dist-tag --scripts-version=@latest | |||
There was a problem hiding this comment.
Revert all changes in this file and keep it consistent with cra5
Tao Fang is working on how to build and test with CRA5
tasks/e2e-kitchensink.sh
Outdated
| @@ -85,7 +85,7 @@ publishToLocalRegistry | |||
|
|
|||
| # Install the app in a temporary location | |||
| cd $temp_app_path | |||
| npx create-react-app test-kitchensink --template=file:"$root_path"/packages/react-scripts/fixtures/kitchensink | |||
| npx create-react-app test-kitchensink --scripts-version=@skyscanner/backpack-react-scripts --template=file:"$root_path"/packages/react-scripts/fixtures/kitchensink | |||
There was a problem hiding this comment.
Revert all changes in this file, and keep it consistent with CRA5,
Tao Fang is working on how to build and test CRA5
tasks/e2e-kitchensink-eject.sh
Outdated
| @@ -116,8 +116,8 @@ REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \ | |||
| npm run build | |||
|
|
|||
| # Check for expected output | |||
| exists build/*.html | |||
| exists build/static/js/main.*.js | |||
| exists build/web/*.html | |||
There was a problem hiding this comment.
Revert all changes in this file, and keep it consistent with CRA5,
Tao Fang is working on how to build and test CRA5
tasks/e2e-simple.sh
Outdated
| @@ -76,51 +76,68 @@ if [ "$EXPECTED" != "$ACTUAL" ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if hash npm 2>/dev/null | |||
There was a problem hiding this comment.
Revert all changes in this file, and keep it consistent with CRA5,
Tao Fang is working on how to build and test CRA5
Revert all changes in this file, and keep it consistent with CRA5, Will create new workflow to build and test BRS
This PR will merge the not BRS features: