[LEOP-287]Apply all customize features to CRA5-Part1 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salleyliu
commented
Apr 26, 2022
| name: isEnvDevelopment, | ||
| cacheGroups: bpkReactScriptsConfig.vendorsChunkRegex | ||
| ? { | ||
| defaultVendors: { |
There was a problem hiding this comment.
in webpack5: optimization.splitChunks.cacheGroups.vendors → optimization.splitChunks.cacheGroups.defaultVendors
salleyliu
commented
Apr 26, 2022
| case 'css': | ||
| return { | ||
| and: [cssRegex, () => !cssModulesEnabled], | ||
| not: [backpackModulesRegex, scopedBackpackModulesRegex], |
There was a problem hiding this comment.
Accroding webpack5 Rule.exclude and Rule.include: If you supply a Rule.exclude option, you cannot also supply a Rule.resource(and, not, or )
So I'm going to change exclude here to not
salleyliu
commented
Apr 26, 2022
| case 'sass': | ||
| return { | ||
| and: [sassRegex, () => !cssModulesEnabled], | ||
| not: [backpackModulesRegex, scopedBackpackModulesRegex], |
There was a problem hiding this comment.
Same above. I'm going to change exclude here to not.
jaysonwu991
reviewed
Apr 26, 2022
packages/react-scripts/backpack-addons/ssr/customWebpackUtils.js
Outdated
Show resolved
Hide resolved
jaysonwu991
reviewed
Apr 26, 2022
jaysonwu991
reviewed
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will merge all add files in react-scripts: