Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LEOP-287]Apply all customize features to CRA5-Part2 #145

Merged
merged 13 commits into from
Apr 27, 2022
Merged

[LEOP-287]Apply all customize features to CRA5-Part2 #145

merged 13 commits into from
Apr 27, 2022

Conversation

salleyliu
Copy link

@salleyliu salleyliu commented Apr 26, 2022 •
edited
Loading

The part includes updating config and script files and other related files:

  • Add custome features in config file
  • Add ssr config in react-scritps
  • Update denpendencies in react-scripts
  • Update changelog and readme file
  • Remove extra space from the end line: css.html and js.html

jaysonwu991
jaysonwu991 reviewed Apr 26, 2022
View reviewed changes
Copy link

@jaysonwu991 jaysonwu991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add #backpack-addons comments and please make sure it is based on the codebase of CRA v5.

packages/react-scripts/README.md Outdated Show resolved Hide resolved
packages/react-scripts/README.md Outdated Show resolved Hide resolved
packages/react-scripts/config/paths.js Outdated Show resolved Hide resolved
packages/react-scripts/config/paths.js Outdated Show resolved Hide resolved
packages/react-scripts/config/paths.js Outdated Show resolved Hide resolved
packages/react-scripts/scripts/build.js Show resolved Hide resolved
packages/react-scripts/scripts/build.js Show resolved Hide resolved
packages/react-scripts/scripts/build.js Show resolved Hide resolved
packages/react-scripts/scripts/start-ssr.js Show resolved Hide resolved
packages/react-scripts/scripts/utils/createJestConfig.js Show resolved Hide resolved
paultan2021
paultan2021 reviewed Apr 27, 2022
View reviewed changes
packages/react-scripts/package.json
"version": "5.0.0",
"description": "Configuration and scripts for Create React App.",
"name": "@skyscanner/backpack-react-scripts",
"version": "10.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 11.0.0 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, does Changelog need to add upgrade information now?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please add

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

paultan2021
paultan2021 approved these changes Apr 27, 2022
View reviewed changes
Copy link

@paultan2021 paultan2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salleyliu @jaysonwu991
Update packages/react-scripts/package.json
7860569 
Co-authored-by: Jayson Wu <jaysonwu991@outlook.com>
@salleyliu salleyliu merged commit 71ee671 into fork_cra5 Apr 27, 2022
@olliecurtis olliecurtis deleted the fork_rebase_part2 branch October 10, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannySu2021 DannySu2021 DannySu2021 left review comments

@jaysonwu991 jaysonwu991 jaysonwu991 left review comments

@paultan2021 paultan2021 paultan2021 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salleyliu @jaysonwu991 @DannySu2021 @paultan2021