[No JIRA]SplitChunks remove name and SubresourceIntegrityPlugin use new import syntax #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salleyliu
changed the title
salleyliu
changed the title
jaysonwu991
reviewed
May 10, 2022
| : {}, | ||
| } | ||
| : {}, | ||
| }; |
There was a problem hiding this comment.
Good to use some common code to implement this functionality, no need to have a deep structure of code.
| @@ -4,23 +4,34 @@ const paths = require('../config/paths'); | |||
| const appPackageJson = require(paths.appPackageJson); | |||
| const bpkReactScriptsConfig = appPackageJson['backpack-react-scripts'] || {}; | |||
|
|
|||
| module.exports = (isEnvDevelopment) => { | |||
| module.exports = isEnvDevelopment => { | |||
There was a problem hiding this comment.
Is this formation changed by husky hooks when executing git commands?
There was a problem hiding this comment.
This is due to formatting the document, and I will restore it.
salleyliu
commented
May 10, 2022
| @@ -1,6 +1,6 @@ | |||
| "use strict"; | |||
|
|
|||
| const SubresourceIntegrityPlugin = require("webpack-subresource-integrity"); | |||
| const { SubresourceIntegrityPlugin } = require("webpack-subresource-integrity"); | |||
There was a problem hiding this comment.
Migrate v1 to v5 use new import syntax, see here.
paultan2021
reviewed
May 10, 2022
| } | ||
| : { | ||
| ...chunksAndGroups, | ||
| name: false, |
There was a problem hiding this comment.
what is the chunk name looks like for both the name: false and without name case?
There was a problem hiding this comment.
when name is false:
when without name:
So the chunk name is the same when the name: false and without name.
paultan2021
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitchunks: in webpack5, optimization.splitChunks name: true removed: Automatic names are no longer supported, see here.
sriEnabled: migrate v1 to v5 use new import syntax, see here.
change files:
namewhen development is tureconst SubresourceIntegrityPlugin = require("webpack-subresource-integrity");toconst { SubresourceIntegrityPlugin } = require("webpack-subresource-integrity")