Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARGG-779]: QoL Updates #174

Merged
merged 5 commits into from
Nov 7, 2023
Merged

[ARGG-779]: QoL Updates #174

merged 5 commits into from
Nov 7, 2023

Conversation

olliecurtis
Copy link
Member

  • Bump Jest,
  • Update Node CI versions to v18,
  • Node-Sass version increase to allow all higher versions
  • Move to peerDeps with sass-embedded
  • Update actions versions

@olliecurtis olliecurtis added the WIP label Nov 6, 2023
@olliecurtis olliecurtis mentioned this pull request Nov 6, 2023
Closed
@olliecurtis
Remove saddlebag and Backpack libraries from default transpilation. A…
ac49615 
…dded a warning if generic paths are used instead of absolutes
@olliecurtis olliecurtis removed the WIP label Nov 7, 2023
@olliecurtis olliecurtis changed the title [WIP][ARGG-779]: QoL Updates [ARGG-779]: QoL Updates Nov 7, 2023
@olliecurtis olliecurtis marked this pull request as ready for review November 7, 2023 13:49
xalechez
xalechez reviewed Nov 7, 2023
View reviewed changes
packages/react-scripts/backpack-addons/babelIncludePrefixes.js
const backpackModulesRegex = /node_modules[\\/]bpk-/;
const saddlebagModulesRegex = /node_modules[\\/]saddlebag-/;
const scopedBackpackModulesRegex = /node_modules[\\/]@skyscanner[\\/]bpk-/;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two lines should also be removed, we don't want to support deprecated packages

Copy link
Member Author

@olliecurtis olliecurtis Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will still need these for bpk-foundations-web.

We can get rid of the non scoped one as the only one not scoped is the logos but that is shipped transpiled

@olliecurtis olliecurtis requested a review from xalechez November 7, 2023 14:54
@olliecurtis olliecurtis merged commit 5b39be2 into fork_cra5 Nov 7, 2023
2 checks passed
@olliecurtis olliecurtis deleted the ARGG-779-QoL-updates branch November 7, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xalechez xalechez xalechez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olliecurtis @xalechez