[ARGG-773]: Changes to support testing with Jest 29 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xalechez
commented
Nov 8, 2023
| @@ -21,8 +21,8 @@ const customModuleRegexes = bpkReactScriptsConfig.babelIncludePrefixes | |||
| : []; | |||
|
|
|||
| // Backpack node module regexes | |||
| const scopedBackpackModulesRegex = /node_modules[\\/]@skyscanner[\\/]bpk-/; | |||
| // const scopedBackpackModulesRegex = /node_modules[\\/]@skyscanner[\\/]bpk-/; | |||
There was a problem hiding this comment.
Removing this for an experiment. Will return later if fails
xalechez
commented
Nov 8, 2023
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| module.exports = { | |||
| process() { | |||
| return 'module.exports = {};'; | |||
| return { code: 'module.exports = {};' }; | |||
xalechez
commented
Nov 8, 2023
| @@ -17,7 +17,8 @@ module.exports = { | |||
| pascalCase: true, | |||
| }); | |||
| const componentName = `Svg${pascalCaseFilename}`; | |||
| return `const React = require('react'); | |||
| return { | |||
| code: `const React = require('react'); | |||
xalechez
commented
Nov 8, 2023
| @@ -26,13 +26,13 @@ | |||
| }, | |||
| "types": "./lib/react-app.d.ts", | |||
| "dependencies": { | |||
| "@babel/core": "^7.18.6", | |||
| "@loadable/babel-plugin": "^5.13.2", | |||
| "@babel/core": "^7.23.2", | |||
There was a problem hiding this comment.
Explicitly bumping dependencies to latest version within the same major. Some of them contain fixes of known issues
xalechez
commented
Nov 8, 2023
| "identity-obj-proxy": "^3.0.0", | ||
| "jest": "^29.7.0", | ||
| "jest-environment-jsdom": "^29.7.0", |
There was a problem hiding this comment.
Needs to be installed manually since Jest 28
xalechez
commented
Nov 8, 2023
| "source-map-loader": "^3.0.0", | ||
| "style-loader": "^3.3.1", | ||
| "tailwindcss": "^3.0.2", | ||
| "sass-loader": "^13.3.2", |
There was a problem hiding this comment.
Bumping major to support node-sass up to 9. None of breaking changes should affect us
xalechez
commented
Nov 8, 2023
| @@ -92,7 +93,7 @@ | |||
| "node-sass": ">=7", | |||
| "react": ">= 17", | |||
| "sass-embedded": "*", | |||
| "typescript": "^3.2.1 || ^4 || ^5" | |||
| "typescript": ">= 4.4.4" | |||
There was a problem hiding this comment.
Drop support for old TypeScript versions
xalechez
commented
Nov 8, 2023
| includePrefixes.unshift('bpk-'); | ||
| includePrefixes.unshift('@skyscanner/bpk-'); | ||
| includePrefixes.unshift('@skyscanner/backpack-web/bpk-mixins'); | ||
| const includePrefixes = bpkReactScriptsConfig.jestIncludePrefixes || []; |
There was a problem hiding this comment.
We need a separate list for Jest as its module resolution mechanism is more strict compared to Webpack, but I still want to pass dependencies by their names instead of using bulk prefixes
xalechez
commented
Nov 8, 2023
| @@ -51,6 +56,9 @@ module.exports = (resolve, rootDir, isEjecting) => { | |||
| '<rootDir>/src/**/*.{spec,test}.{js,jsx,ts,tsx}', | |||
| ], | |||
| testEnvironment: 'jsdom', | |||
| testEnvironmentOptions: { | |||
olliecurtis
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.