[ARGG-775]: Fixed icon loading in JS and SCSS #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xalechez
commented
Nov 9, 2023
| @@ -481,17 +486,6 @@ module.exports = function (webpackEnv) { | |||
| // @remove-on-eject-end | |||
| plugins: [ | |||
| require.resolve('@loadable/babel-plugin'), | |||
| [ | |||
There was a problem hiding this comment.
No longer needed, a CRA4 legacy
xalechez
commented
Nov 9, 2023
| @@ -134,7 +134,12 @@ module.exports = function (webpackEnv) { | |||
| }, | |||
| { | |||
| loader: require.resolve('css-loader'), | |||
| options: cssOptions, | |||
| options: { | |||
There was a problem hiding this comment.
Prevent creating separate files for data-* svg icons
olliecurtis
approved these changes
Nov 9, 2023
olliecurtis
reviewed
Nov 9, 2023
| @@ -427,9 +433,14 @@ module.exports = function (webpackEnv) { | |||
| loader: require.resolve('@svgr/webpack'), | |||
| options: { | |||
| prettier: false, | |||
| svgo: false, | |||
| svgo: true, | |||
There was a problem hiding this comment.
Not blocking but we could consider not even needing this option as the latest version of svgr/webpack sets this to true by default: https://react-svgr.com/docs/options/#svgo
| plugins: [ | ||
| { | ||
| name: 'preset-default', | ||
| removeViewBox: false, |
There was a problem hiding this comment.
Looking at the docs this might not 'just work' and the config looks to be a bit more in an object to override: https://github.com/svg/svgo#default-preset
So possibly needs to be
params: {
overrides: {
removeViewBox: false
}
}
olliecurtis
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.