[ARGG-864]: Experimental esbuild-loader support #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xalechez
commented
Nov 14, 2023
•
xalechez
commented
- Added esbuild-loader as an opt-in built time optimisation
- Added conversion of browserslist config to esbuild target
- Added support of keeping babel-loader for loadable components which is a hard requirement for them to work the same way as before
- I also tried to add EsbuildPlugin for minification and definitions, but it somehow showed worse results in test apps than TerserPlugin + DefinePlugin
xalechez
force-pushed
the
ARGG-864
branch
4 times, most recently
from
0428bdc to
e05a9ea
Compare
xalechez
commented
Nov 15, 2023
| { | ||
| // Loadable Components require special treatment with Babel plugin | ||
| // When used with Esbuild loader, they should still be transpiled with Babel first | ||
| test: /\.loadable\.(ts|js)$/, |
There was a problem hiding this comment.
We can't identify loadable components files other than by a prefix, so this is a suggestion - if you want esbuild-loader, make sure your LCs are wrapped into special files
olliecurtis
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.