[LOOM-1341]: update eslint-config-skyscanner@18 & include forbid rule #3343
Conversation
|
Visit https://backpack.github.io/storybook-prs/3343 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3343 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3343 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3343 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3343 to see this build running in a browser. |
mungodewar
changed the title
| }, | ||
| "overrides": [ | ||
| { | ||
| "files": ["*test*", "*examples*"], |
There was a problem hiding this comment.
We want to continue using Bpk components within our tests and examples as our consumers are, so we are not interested in disallowing className usage there.
| @@ -0,0 +1,96 @@ | |||
| ### Avoid className props | |||
There was a problem hiding this comment.
Docs basically ripped from banana
|
Visit https://backpack.github.io/storybook-prs/3343 to see this build running in a browser. |
mungodewar
changed the title
|
Visit https://backpack.github.io/storybook-prs/3343 to see this build running in a browser. |
…#3343) * update linter and --fix * update ts-expect-error lines * update ts-expect-error lines * inline ignore className usage * add missing snaps * align all comments to the same TODO * remove unused comments * lock file update
…#3343) * update linter and --fix * update ts-expect-error lines * update ts-expect-error lines * inline ignore className usage * add missing snaps * align all comments to the same TODO * remove unused comments * lock file update
…#3343) * update linter and --fix * update ts-expect-error lines * update ts-expect-error lines * inline ignore className usage * add missing snaps * align all comments to the same TODO * remove unused comments * lock file update
Tasks:
classNameusage with TODO statement to be removed in future workChanges:
commonButtonTestsinto an actual test that imports different buttons, rather than exporting a test helper that was used in each button test suite. This was because we have a*test*regex andcommonButtonTestswasn't matching this. It was an unusual pattern of testing and I thought it cleaner to remove it and have a single place for testing the common tests for Button instead.Remember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md.d.ts) files updated