Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARGG-946 Add @skyscanner/eslint-plugin-rules@1.0.1 to dependencies #692

Merged
merged 2 commits into from
Jan 22, 2024
Merged

ARGG-946 Add @skyscanner/eslint-plugin-rules@1.0.1 to dependencies #692

merged 2 commits into from
Jan 22, 2024

Conversation

soulcheck
Copy link
Contributor

@soulcheck soulcheck commented Jan 22, 2024 •
edited
Loading

What:

  • Adds dependency on @skyscanner/eslint-plugin-rules (@1.0.1) and configures no-axios rule to "error" by default
  • Removes the local dependency on skyscanner-no-axios.

Why

  • Due to npm bug it is currently impossible to update eslint-config-skyscanner since it contains a local dependency on skyscanner-no-axios This PR should fix that.

@soulcheck soulcheck changed the title ARGG-946 add eslint plugin rules ARGG-946 Add @skyscanner/eslint-plugin-rules@1.0.1 to dependencies Jan 22, 2024
@soulcheck soulcheck added the minor label for minor changes label Jan 22, 2024
@soulcheck soulcheck merged commit d40ec3c into main Jan 22, 2024
3 of 4 checks passed
@soulcheck soulcheck deleted the ARGG-946_add_eslint_plugin_rules branch January 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliecurtis olliecurtis olliecurtis approved these changes

Assignees
No one assigned
Labels
minor label for minor changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulcheck @olliecurtis