Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make all Dungeon solver colors customizable #487

Merged
merged 7 commits into from
Jul 6, 2024
Merged

feat: Make all Dungeon solver colors customizable #487

merged 7 commits into from
Jul 6, 2024

Conversation

Coccocoahelper
Copy link
Contributor

Not ready yet, but likely not going to break things. Try it once it compiles.

@Coccocoahelper
feat: Make all Dungeon solver colors customizable
346950e 
Not ready, but likely not going to break thing

Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <157546848+Coccocoahelper@users.noreply.github.com>
@Coccocoahelper
Maybe done
98c7695
@Coccocoahelper Coccocoahelper marked this pull request as ready for review June 26, 2024 09:04
Sychic
Sychic requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@Sychic Sychic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e: file:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:20:38 Unresolved reference: config
e: file:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:38:9 Unresolved reference: ticTacToeSolverColor

@Coccocoahelper
Copy link
Contributor Author

e: file:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:20:38 Unresolved reference: config e: file:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:38:9 Unresolved reference: ticTacToeSolverColor

My bad, fixing it.

@Coccocoahelper
Copy link
Contributor Author

e: file:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:20:38 Unresolved reference: config e: file:///home/runner/work/SkytilsMod/SkytilsMod/src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/renderer/TileEntityChestRendererHook.kt:38:9 Unresolved reference: ticTacToeSolverColor

Can you make it try to compile rn?

@Coccocoahelper
Update TileEntityChestRendererHook.kt
46602f3 
Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <157546848+Coccocoahelper@users.noreply.github.com>
@Coccocoahelper
revert
527f8e9
@Coccocoahelper
Copy link
Contributor Author

Doesn't compile because of Gradle dependencies (?). I need someone to take a closer look at the errors.

@Sychic
fix import
a9977d0
@Sychic
Fix missing package
0a59b9f 
???????????????????????????????????????????????????????????
@Sychic Sychic merged commit a108b41 into Skytils:dev Jul 6, 2024
1 check passed
Sychic added a commit to Desco1/SkytilsMod-Score that referenced this pull request Jul 17, 2024
@Coccocoahelper @Sychic
feat: make all dungeon solver colors customizable (Skytils#487)
e24f73d 
* feat: Make all Dungeon solver colors customizable

Not ready, but likely not going to break thing

Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <157546848+Coccocoahelper@users.noreply.github.com>

* Maybe done

* maybe a proper fix

* Update TileEntityChestRendererHook.kt

Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <157546848+Coccocoahelper@users.noreply.github.com>

* revert

* fix import

* Fix missing package

???????????????????????????????????????????????????????????

---------

Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <157546848+Coccocoahelper@users.noreply.github.com>
Co-authored-by: sychic <47618543+Sychic@users.noreply.github.com>
Kemmisch added a commit to Kemmisch/SkytilsMod that referenced this pull request Jul 31, 2024
@Kemmisch
Merge pull request #24 from Skytils/dev
78a2acb 
feat: make all dungeon solver colors customizable (Skytils#487)
My-Name-Is-Jeff pushed a commit that referenced this pull request Aug 9, 2024
@Coccocoahelper @Sychic @My-Name-Is-Jeff
feat: make all dungeon solver colors customizable (#487)
22c8038 
Signed-off-by: thatonecoder (formerly Coccocoa's Helper) <157546848+Coccocoahelper@users.noreply.github.com>
Co-authored-by: sychic <47618543+Sychic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sychic Sychic Sychic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coccocoahelper @Sychic