fix: update spider's den rain time #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated nextRain time used for calculations to now show correct rain times. Time used: Unix (in milliseconds): 1727548440000 Human Time: GMT Saturday, September 28, 2024 6:34:00 PM Skyblock Time: Year 375, Late Autumn, Day 19 Signed-off-by: L3cache <85846799+level3cache@users.noreply.github.com>
|
Edit: I found a way to build the mod with my updated changes, found out it's still not working correctly. I'll try to get it working and follow up with another (working) fix for it asap |
Actually fix spider's den rain time feature not showing correct time. Added new variables to make future changes easier with additional helpful comments to further clarify, what each value has to be set to. Signed-off-by: L3cache <85846799+level3cache@users.noreply.github.com>
forgot to update nextRain value, because it was one minute behind Signed-off-by: L3cache <85846799+level3cache@users.noreply.github.com>
|
I fixed the timings and added two new variables to make future edits easier. This pr is now ready to be reviewed. |
My-Name-Is-Jeff
requested changes
Sep 29, 2024
src/main/kotlin/gg/skytils/skytilsmod/features/impl/spidersden/RainTimer.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/skytils/skytilsmod/features/impl/spidersden/RainTimer.kt
Outdated
Show resolved
Hide resolved
Changed `var` to `const val` for compiler optimizations Signed-off-by: L3cache <85846799+level3cache@users.noreply.github.com>
My-Name-Is-Jeff
requested changes
Sep 29, 2024
src/main/kotlin/gg/skytils/skytilsmod/features/impl/spidersden/RainTimer.kt
Outdated
Show resolved
Hide resolved
reverted one `const val` to `var` because it's value changes on line 37 Signed-off-by: L3cache <85846799+level3cache@users.noreply.github.com>
My-Name-Is-Jeff
approved these changes
Oct 2, 2024
|
Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated nextRain time used for calculations to now show correct rain times.
Time used:
Unix (in milliseconds): 1727548440000
Human Time: GMT Saturday, September 28, 2024 6:34:00 PM Skyblock Time: Year 375, Late Autumn, Day 19
I was unable to create a succesful build of the Mod to test these changes myselfe, please test it before pushing. I'm new to programming and hope this works like it should.