Task node section tooltips and misc updates #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `HelpTooltip` component and integrate into `TaskNode` for enhanced tooltips and update labels/placeholders for clarity. > > - **Components**: > - Add `HelpTooltip` component in `HelpTooltip.tsx` for displaying tooltips with `QuestionMarkCircledIcon`. > - **TaskNode**: > - Integrate `HelpTooltip` in `TaskNode.tsx` for sections: Content, Extraction, Limits, Two-Factor Authentication, and Display Mode. > - Update labels and placeholders in `TaskNode.tsx` for clarity, e.g., "Allow Downloads" to "Complete on Download". > - **Types**: > - Add `helpTooltipContent` in `types.ts` to store tooltip content for different sections. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 649c5095ae115e51ec96f8a63ac26525840785af. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `HelpTooltip` component and integrate into `TaskNode` for enhanced tooltips and update labels/placeholders for clarity. > > - **Components**: > - Add `HelpTooltip` component in `HelpTooltip.tsx` for displaying tooltips with `QuestionMarkCircledIcon`. > - **TaskNode**: > - Integrate `HelpTooltip` in `TaskNode.tsx` for sections: Content, Extraction, Limits, Two-Factor Authentication, and Display Mode. > - Update labels and placeholders in `TaskNode.tsx` for clarity, e.g., "Allow Downloads" to "Complete on Download". > - **Types**: > - Add `helpTooltipContent` in `types.ts` to store tooltip content for different sections. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 649c5095ae115e51ec96f8a63ac26525840785af. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2da60bc in 10 seconds
More details
- Looked at
252lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts:44
- Draft comment:
Consider makinghelpTooltipContentmore dynamic or configurable to allow easier updates or localization in the future. - Reason this comment was not posted:
Confidence changes required:50%
TheHelpTooltipcomponent is being used correctly, but the tooltip content is hardcoded in thetypes.tsfile. This could be improved by making it more dynamic or configurable.
Workflow ID: wflow_mlr4KKhMhI3l9tmQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 2da60bc in 14 seconds
More details
- Looked at
269lines of code in5files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNodeParametersPanel.tsx:2
- Draft comment:
Remove unused imports related toTooltipcomponents, as they are no longer used after refactoring toHelpTooltip. - Reason this comment was not posted:
Confidence changes required:50%
The import statement forTooltipcomponents inTaskNodeParametersPanel.tsxis unnecessary after the refactor to useHelpTooltip.
2. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:138
- Draft comment:
Consider creating a reusable component or function for the repeatedHelpTooltipusage to avoid code repetition and improve maintainability. - Reason this comment was not posted:
Confidence changes required:50%
TheHelpTooltipcomponent is used multiple times with similar structure. Consider creating a reusable component or function to avoid repetition.
3. skyvern/forge/sdk/workflow/service.py:1050
- Draft comment:
Verify the removal of additional parameters inLOG.errorcall for correctness. Ensure that the logging still provides sufficient context for debugging. - Reason this comment was not posted:
Confidence changes required:33%
TheLOG.errorcall increate_workflow_from_requestmethod was modified to remove additional parameters. This change should be verified for correctness.
Workflow ID: wflow_StF9HxRZMOgkJoxp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on fa020aa in 9 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:1051
- Draft comment:
The PR description mentions removing redundant parameters in error logging, but this change addsorganization_idto the log message. Please clarify if this is intended. - Reason this comment was not posted:
Confidence changes required:50%
The logging change in the PR description mentions removing redundant parameters, but the change actually adds a parameter to the log message. This seems to be a misunderstanding or miscommunication in the PR description.
Workflow ID: wflow_mJAJ748ebU31zEQM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
HelpTooltipcomponent toTaskNodefor enhanced tooltips and update labels/placeholders for clarity.HelpTooltipcomponent inHelpTooltip.tsxfor displaying tooltips withQuestionMarkCircledIcon.HelpTooltipinTaskNode.tsxfor sections: Content, Extraction, Limits, Two-Factor Authentication, and Display Mode.TaskNode.tsxfor clarity, e.g., "Allow Downloads" to "Complete on Download".helpTooltipContentintypes.tsto store tooltip content for different sections.TaskNodeParametersPanel.tsx.This description was created by
for fa020aa. It will automatically update as commits are pushed.