Fix whitespace bug for SendEmailBlock #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Fixes whitespace bug in `getWorkflowBlock()` in `workflowEditorUtils.ts` by trimming whitespace from `file_attachments` and `recipients` fields for `send_email` blocks. > > - **Behavior**: > - Fixes whitespace bug in `getWorkflowBlock()` in `workflowEditorUtils.ts` by trimming whitespace from `file_attachments` and `recipients` fields for `send_email` blocks. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 730fe7d03c3b36accfb8eecf9934ded7f61ef61a. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on e4b14dc in 8 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:511
- Draft comment:
Trimming whitespace from 'file_attachments' and 'recipients' is a good practice to ensure data consistency. - Reason this comment was not posted:
Confidence changes required:0%
The PR correctly trims whitespace from the 'file_attachments' and 'recipients' fields in the 'send_email' block. This is a good practice to ensure data consistency and prevent errors due to unexpected whitespace.
Workflow ID: wflow_4Fb9sGkw3fwxTowE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to e4b14dc in 8 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:511
- Draft comment:
Trimming whitespace fromfile_attachmentsandrecipientsis a good practice to ensure data consistency and prevent errors due to unexpected whitespace. - Reason this comment was not posted:
Confidence changes required:0%
The PR correctly trims whitespace from thefile_attachmentsandrecipientsfields in thegetWorkflowBlockfunction. This change is consistent with the PR description and addresses the whitespace bug.
Workflow ID: wflow_EbZ5qBGqVjylLFgG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 75d5a63 in 8 seconds
More details
- Looked at
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:511
- Draft comment:
Consider improving code readability by aligning the chained methods forfile_attachmentsandrecipients. - Reason this comment was not posted:
Confidence changes required:33%
The PR description indicates a fix for whitespace handling ingetWorkflowBlock()forsend_emailblocks. The changes made are correct and improve the robustness of the code by trimming whitespace fromfile_attachmentsandrecipients. However, the formatting of the code can be improved for better readability.
Workflow ID: wflow_ceuYTmrneeO4wwGr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes whitespace handling in
getWorkflowBlock()forsend_emailblocks by trimming whitespace fromfile_attachmentsandrecipientsfields.getWorkflowBlock()inworkflowEditorUtils.tsby trimming whitespace fromfile_attachmentsandrecipientsfields forsend_emailblocks.This description was created by
for 75d5a63. It will automatically update as commits are pushed.