Show only standalone tasks in task pages #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `only_standalone_tasks` filter to task API requests in `TaskHistory`, `QueuedTasks`, and `RunningTasks`. > > - **Behavior**: > - Add `only_standalone_tasks: "true"` to API requests in `TaskHistory`, `QueuedTasks`, and `RunningTasks` to filter tasks. > - **Components**: > - `TaskHistory`: Filters completed, failed, terminated, timed out, and canceled tasks. > - `QueuedTasks`: Filters queued tasks. > - `RunningTasks`: Filters running tasks. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c9af0ad174af6f36019d6c93f2660f2b8bc9fc1c. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 38a1545 in 16 seconds
More details
- Looked at
38lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/running/QueuedTasks.tsx:26
- Draft comment:
Consider adding error handling for the API request to handle potential errors gracefully, similar to how it's done inTaskHistory. This applies toRunningTasksas well. - Reason this comment was not posted:
Confidence changes required:50%
The code in all three files is consistent with the PR description, which is to add theonly_standalone_tasksfilter to the API requests. The changes are straightforward and correctly implemented. However, there is a potential issue with error handling in theQueuedTasksandRunningTaskscomponents, where errors are not handled, unlike inTaskHistory. This could lead to unhandled promise rejections or silent failures.
2. skyvern-frontend/src/routes/tasks/running/RunningTasks.tsx:26
- Draft comment:
Consider adding error handling for the API request to handle potential errors gracefully, similar to how it's done inTaskHistory. This applies toQueuedTasksas well. - Reason this comment was not posted:
Confidence changes required:50%
The code in all three files is consistent with the PR description, which is to add theonly_standalone_tasksfilter to the API requests. The changes are straightforward and correctly implemented. However, there is a potential issue with error handling in theQueuedTasksandRunningTaskscomponents, where errors are not handled, unlike inTaskHistory. This could lead to unhandled promise rejections or silent failures.
Workflow ID: wflow_eQpFWFSupJ2bcK5H
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 38a1545 in 21 seconds
More details
- Looked at
38lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/running/QueuedTasks.tsx:26
- Draft comment:
Consider adding error handling for the useQuery hook to manage potential API request failures. This is applicable in RunningTasks as well. - Reason this comment was not posted:
Confidence changes required:50%
The code changes are consistent with the PR description, which aims to filter tasks by standalone status. However, there is a potential issue with error handling in the QueuedTasks and RunningTasks components.
2. skyvern-frontend/src/routes/tasks/running/RunningTasks.tsx:26
- Draft comment:
Consider adding error handling for the useQuery hook to manage potential API request failures. This is applicable in QueuedTasks as well. - Reason this comment was not posted:
Confidence changes required:50%
The code changes are consistent with the PR description, which aims to filter tasks by standalone status. However, there is a potential issue with error handling in the QueuedTasks and RunningTasks components.
Workflow ID: wflow_BX11RLLEgPlvHmDE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
deleted the
salih/show-standalone-tasks-only-in-task-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
only_standalone_tasksfilter to task API requests inTaskHistory,QueuedTasks, andRunningTasks.only_standalone_tasks: "true"to API requests inTaskHistory,QueuedTasks, andRunningTasksto filter tasks.TaskHistory: Filters completed, failed, terminated, timed out, and canceled tasks.QueuedTasks: Filters queued tasks.RunningTasks: Filters running tasks.This description was created by
for 38a1545. It will automatically update as commits are pushed.