Change limit field width and file suffix placeholder #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Increase input field widths in `TaskNode.tsx` and update `downloadSuffix` placeholder in `types.ts`. > > - **UI Changes in `TaskNode.tsx`**: > - Increase width of input fields for `maxRetries`, `maxStepsOverride`, `allowDownloads`, and `downloadSuffix` from `w-44` to `w-52`. > - **Placeholder Update in `types.ts`**: > - Change `downloadSuffix` placeholder from "Suffix for file downloads" to "Add an ID for downloaded files". > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for d8f529960651ad89b56f848f4e89a0a8a9135d4e. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9d52848 in 10 seconds
More details
- Looked at
54lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts:60
- Draft comment:
The placeholder fordownloadSuffixhas been updated correctly. - Reason this comment was not posted:
Confidence changes required:0%
The placeholder fordownloadSuffixhas been updated correctly in thefieldPlaceholdersobject.
Workflow ID: wflow_nblXKrWl3T9Y7k80
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9d52848 in 11 seconds
More details
- Looked at
54lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:266
- Draft comment:
The width of the input fields has been increased fromw-44tow-52as per the PR description. Ensure that this change does not affect the layout negatively in smaller viewports. - Reason this comment was not posted:
Confidence changes required:33%
The PR description mentions updating the placeholder fordownloadSuffix, which is correctly reflected in the code changes. However, the description also mentions increasing the width of input fields, which is correctly implemented in theTaskNode.tsxfile. The changes are consistent with the description and do not introduce any issues.
Workflow ID: wflow_dBKG0B6xQ8s0WPTD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Increase input field widths in
TaskNode.tsxand updatedownloadSuffixplaceholder intypes.ts.TaskNode.tsx:maxRetries,maxStepsOverride,allowDownloads, anddownloadSuffixfromw-44tow-52.types.ts:downloadSuffixplaceholder from "Suffix for file downloads" to "Add an ID for downloaded files".This description was created by
for 9d52848. It will automatically update as commits are pushed.