Ensure consistency in button severity between workflow and task runs #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Ensure button label and icon consistency in `TaskDetails.tsx` and `WorkflowRun.tsx`. > > - **UI Consistency**: > - Change button variant from `outline` to `secondary` in `TaskDetails.tsx`. > - Update button labels from "Copy as cURL" to "Copy cURL" in `TaskDetails.tsx` and `WorkflowRun.tsx`. > - Update button labels from "Rerun Task" and "Rerun Workflow" to "Rerun" in `TaskDetails.tsx` and `WorkflowRun.tsx`. > - Add `PlayIcon` to "Rerun" button in `TaskDetails.tsx` and `WorkflowRun.tsx`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 6f8fe3ff202ac7aa20f596b44e8a4a94feb279c8. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b1979a7 in 15 seconds
More details
- Looked at
74lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:294
- Draft comment:
Consider updating the button label fromEdit WorkflowtoEditfor consistency with other button labels. - Reason this comment was not posted:
Confidence changes required:50%
The PR description specifies changing button labels for consistency. The label 'Edit Workflow' should be updated to 'Edit' for consistency with other buttons.
Workflow ID: wflow_R7pnj5CrXTNXdM99
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b1979a7 in 18 seconds
More details
- Looked at
74lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx:194
- Draft comment:
The 'Edit' button label should also be updated for consistency, similar to the changes made in WorkflowRun.tsx. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_KXqohMj8h04SqdtI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Ensure button label and icon consistency in
TaskDetails.tsxandWorkflowRun.tsx.outlinetosecondaryinTaskDetails.tsx.TaskDetails.tsxandWorkflowRun.tsx.TaskDetails.tsxandWorkflowRun.tsx.PlayIconto "Rerun" button inTaskDetails.tsxandWorkflowRun.tsx.This description was created by
for b1979a7. It will automatically update as commits are pushed.