Update the example prompts and add overflow #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Update example prompts and add horizontal overflow handling in `PromptBox.tsx`. > > - **Example Prompts**: > - Added new example prompts: "What is the top NYT bestseller?", "What is the top ranked football team?", "Find the top selling electrical connector on finditparts" in `PromptBox.tsx`. > - **UI Enhancements**: > - Added `overflow-x-scroll` to the example prompts container in `PromptBox.tsx` to handle horizontal overflow. > - Added `whitespace-nowrap` to example prompt items to prevent text wrapping in `PromptBox.tsx`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 9cd38c31add4e6dd76d117589e4acce6f98658c2. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d97d64a in 12 seconds
More details
- Looked at
29lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:179
- Draft comment:
Consider adding amax-wclass to limit the width of the container and prevent potential layout issues. - Reason this comment was not posted:
Confidence changes required:50%
The use ofoverflow-x-scrollandwhitespace-nowrapis appropriate for handling horizontal overflow and preventing text wrapping, respectively. However, theoverflow-x-scrollclass should be accompanied by amax-wclass to ensure the container doesn't grow indefinitely, which could lead to layout issues.
Workflow ID: wflow_yngUmlX635ffDAfX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d97d64a in 17 seconds
More details
- Looked at
29lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:179
- Draft comment:
Consider addingoverflow-y-hiddento prevent vertical scrollbars.
<div className="flex gap-4 overflow-x-scroll overflow-y-hidden rounded-sm bg-slate-elevation1 p-4">
- Reason this comment was not posted:
Confidence changes required:50%
The use ofoverflow-x-scrollandwhitespace-nowrapis appropriate for handling horizontal overflow and preventing text wrapping, respectively. However, theoverflow-x-scrollclass should be accompanied byoverflow-y-hiddento prevent any potential vertical scrollbars from appearing, which could affect the UI aesthetics.
Workflow ID: wflow_LD8I0fQO27UMCJjM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update example prompts and add horizontal overflow handling in
PromptBox.tsx.PromptBox.tsx.overflow-x-scrollto the example prompts container inPromptBox.tsxto handle horizontal overflow.whitespace-nowrapto example prompt items to prevent text wrapping inPromptBox.tsx.This description was created by
for d97d64a. It will automatically update as commits are pushed.