Make scrollable areas more consistent #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Introduce `ScrollAreaViewport` for consistent scrollable areas and update its usage in `PromptBox.tsx`, `ScrollableActionList.tsx`, and `WorkflowParametersPanel.tsx`. > > - **Components**: > - Add `ScrollAreaViewport` component in `scroll-area.tsx` for consistent scrollable areas. > - Export `ScrollAreaViewport` from `scroll-area.tsx`. > - **Usage**: > - Update `PromptBox.tsx` to use `ScrollAreaViewport` for wrapping scrollable content. > - Update `ScrollableActionList.tsx` to use `ScrollAreaViewport` for wrapping scrollable content. > - Update `WorkflowParametersPanel.tsx` to use `ScrollAreaViewport` for wrapping scrollable content. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 666630959469d776701abcd7b567de63399eece2. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 88803e7 in 14 seconds
More details
- Looked at
358lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:185
- Draft comment:
Consider creating a constant for the repeatedclassNamevalue"h-full w-full rounded-[inherit]"used inScrollAreaViewportto avoid repetition and potential errors. This is also applicable inScrollableActionList.tsxandWorkflowParametersPanel.tsx. - Reason this comment was not posted:
Confidence changes required:50%
TheScrollAreaViewportcomponent is being used correctly in multiple files, but theclassNameprop is being repeated with the same value"h-full w-full rounded-[inherit]". This can be refactored to avoid repetition and potential errors in the future.
Workflow ID: wflow_0fjWqOo0i5Q1mFL0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 88803e7 in 20 seconds
More details
- Looked at
358lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:185
- Draft comment:
TheclassNameprop forScrollAreaViewportincludesh-full w-full rounded-[inherit], which might be redundant if the parentScrollAreaalready handles these styles. Consider reviewing the necessity of these styles here and in other files likeScrollableActionList.tsxandWorkflowParametersPanel.tsx. - Reason this comment was not posted:
Confidence changes required:50%
TheScrollAreaViewportcomponent is used consistently across the files, but theclassNameprop is not always necessary. InPromptBox.tsx,ScrollableActionList.tsx, andWorkflowParametersPanel.tsx, theclassNameprop forScrollAreaViewportincludesh-full w-full rounded-[inherit], which might not be needed if the parentScrollAreaalready handles these styles. This could lead to redundant styling.
Workflow ID: wflow_T1POGbIvoX2gfOWH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduce
ScrollAreaViewportfor consistent scrollable areas and update its usage inPromptBox.tsx,ScrollableActionList.tsx, andWorkflowParametersPanel.tsx.ScrollAreaViewportcomponent inscroll-area.tsxfor consistent scrollable areas.ScrollAreaViewportfromscroll-area.tsx.PromptBox.tsxto useScrollAreaViewportfor wrapping scrollable content.ScrollableActionList.tsxto useScrollAreaViewportfor wrapping scrollable content.WorkflowParametersPanel.tsxto useScrollAreaViewportfor wrapping scrollable content.This description was created by
for 88803e7. It will automatically update as commits are pushed.