Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yes/no radio input #955

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix yes/no radio input #955

merged 1 commit into from
Oct 11, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 11, 2024

Important

Fixes radio/checkbox input handling in domUtils.js and simplifies _trimmed_attributes() in scraper.py.

  • Behavior:
    • In domUtils.js, buildElementObject() now sets checked=false for radio and checkbox inputs if checked and aria-checked are absent.
  • Code Simplification:
    • In scraper.py, removed redundant condition in _trimmed_attributes() that checked for truthy values in RESERVED_ATTRIBUTES.

This description was created by Ellipsis for 3cfa10c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3cfa10c in 13 seconds

More details
  • Looked at 35 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/scraper/scraper.py:575
  • Draft comment:
    The condition if key in RESERVED_ATTRIBUTES and attributes[key]: was redundant because attributes[key] is always truthy if the key exists. The updated condition if key in RESERVED_ATTRIBUTES: is correct and improves clarity.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the condition for RESERVED_ATTRIBUTES in _trimmed_attributes function is correct. The previous condition was redundant because the key is already checked to be in RESERVED_ATTRIBUTES. The change improves code clarity.

Workflow ID: wflow_O32AOJHfcoIigc87


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 3a93558 into main Oct 11, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-radio-input-yes-no branch October 11, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant