Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /tmp persistant volumn in docker compose #956

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 11, 2024

Important

Remove persistent volume mapping ./files:/tmp from skyvern service in docker-compose.yml.

  • Docker Compose Configuration:
    • Removed persistent volume mapping ./files:/tmp from the skyvern service in docker-compose.yml.

This description was created by Ellipsis for e473394. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e473394 in 6 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docker-compose.yml:33
  • Draft comment:
    Ensure that removing the /tmp volume does not affect any application functionality that relies on temporary file storage.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the /tmp volume might affect temporary file storage if the application relies on it.

Workflow ID: wflow_ERiUM3wQ3QkceelJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit c239927 into main Oct 11, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-docker-compose-run branch October 11, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant