-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stream zoomable #961
Make stream zoomable #961
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `ZoomableImage` component to enable zoom functionality for images in `TaskActions` and `WorkflowRun`. > > - **Components**: > - Add `ZoomableImage` component in `ZoomableImage.tsx` for image zooming on click. > - Replace `<img>` with `ZoomableImage` in `TaskActions` and `WorkflowRun`. > - **Behavior**: > - Clicking images in `TaskActions` and `WorkflowRun` opens a zoomable modal. > - Modal closes with escape key or close button. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 572e9db2ced979e13bda7b7c1ce0421f54d85a4e. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on be7e35b in 21 seconds
More details
- Looked at
158
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_QdXoeIjBsvNtbCKb
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
onClick={() => { | ||
deleteWorkflowMutation.mutate(id); | ||
}} | ||
disabled={deleteWorkflowMutation.isPending} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleteWorkflowMutation.isPending
should be deleteWorkflowMutation.isLoading
to correctly reflect the loading state of the mutation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to be7e35b in 26 seconds
More details
- Looked at
158
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/DeleteWorkflowButton.tsx:81
- Draft comment:
UsedeleteWorkflowMutation.isLoading
instead ofisPending
to check if the mutation is in progress. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is about a specific change in the code, which is the use ofdeleteWorkflowMutation.isPending
. The suggestion to useisLoading
instead could be valid ifisLoading
is the correct property to check for mutation progress in theuseMutation
hook from@tanstack/react-query
. I need to verify ifisPending
is a valid property or ifisLoading
is the correct one to use.
I might be missing the context of whetherisPending
is a valid property in theuseMutation
hook. IfisPending
is not a valid property, the comment is correct. However, ifisPending
is valid, the comment is unnecessary.
I should verify the properties available in theuseMutation
hook from@tanstack/react-query
to ensure the comment's accuracy.
Check ifisPending
is a valid property in theuseMutation
hook. If not, the comment is correct and should be kept.
Workflow ID: wflow_B1fxDZ1ERA6Pkauc
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add
ZoomableImage
component for image zooming inTaskActions
andWorkflowRun
, and introduceDeleteWorkflowButton
for workflow deletion.ZoomableImage
component inZoomableImage.tsx
for image zooming on click.DeleteWorkflowButton
component inDeleteWorkflowButton.tsx
for deleting workflows.<img>
withZoomableImage
inTaskActions
andWorkflowRun
.TaskActions
andWorkflowRun
opens a zoomable modal.This description was created by for be7e35b. It will automatically update as commits are pushed.