#54 style: 농구장 자세히 보기 UI 수정 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 아이콘 추가, 변경 - DB 완성 전 fake data 활용
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jiiker
reviewed
Feb 1, 2024
| {selectedPlace.convenience.map((tag: string, idx: number) => ( | ||
| <li | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| key={idx} |
There was a problem hiding this comment.
DB에 저장될 때 배열로 저장되는 건 웬만하면 id 넣어주고 그 id 값으로 key를 주는 게 좋긴 할 것 같은데.. 사실 태그는 idx로 줘도 전혀 문제될 게 없긴 해서 이 부분이 애매하긴 하네요.. 이건 eslint 무시하고 하는 걸로 하실건가요??
There was a problem hiding this comment.
jsx-eslint/eslint-plugin-react#1123
단순 배열 나열로 idx로 줘도 문제가 없을 것 같아서 그렇게 했습니다!
- style: 시설 채팅 스타일 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 #54 작업 내용
스크린샷
특이사항