Driver & Constructor Standings from Server #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…see if server is active
Lombardoc4
force-pushed
the
standings-test
branch
2 times, most recently
from
5f0e6ec
to
ecc5b77
Compare
Initialize the use of standings data from the server Refactor the drivers and constructors standings ui Include results type declarations at results.d.ts Update faker data to match standings schema
Lombardoc4
force-pushed
the
standings-test
branch
from
ecc5b77
to
50afa96
Compare
src/app/lib/utils.tsx
Outdated
| @@ -1,4 +1,5 @@ | |||
| import { faker } from '@faker-js/faker'; | |||
| import axios from 'axios'; | |||
There was a problem hiding this comment.
@Lombardoc4 is there any particular reason to use axios over fetch?
There was a problem hiding this comment.
A little more comfortability in the moment. Going to refactor this away along with faker in next rev to start to properly handle server errors.
src/app/lib/utils.tsx
Outdated
| export const fetchAPI = async (endpoint: string) => { | ||
| const server = document.body.classList.contains('server'); | ||
| const dummy: string[] | ISchedule[] | false = | ||
| const serverURL = 'http://127.0.0.1:8081'; |
There was a problem hiding this comment.
can we move this to a dedicated constants file?
|
looks good to me. |
borolepratik
previously approved these changes
Jan 23, 2024
Lombardoc4
force-pushed
the
standings-test
branch
from
40ccc1c
to
6c8b8b1
Compare
borolepratik
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching data from the server and populating the revised look of the driver and constructor standings.