Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI - Tracker assignment options #1009

Merged
merged 18 commits into from
Jun 17, 2024

Conversation

ZycaR
Copy link
Contributor

@ZycaR ZycaR commented Apr 25, 2024

  • Added multiple tracker assignment options according common use cases.
  • In case there is specific number of trackers connected,
    the options with 'less' trackers are disabled and first available option is selected.

Available Options (feel free to suggest better options or wordings):
x5 Lower-Body Set: chest, upper & lower legs
x6 Core Set: chest, hip, upper & lower legs
x8 Enhanced Core Set: chest, hip, upper & lower legs, foots
x10 Full Body Tracking (FBT): chest, hip, upper arms, upper & lower legs, foots

image

ability to select number of trackers (old version):
tracker-options

Added multiple tracker assignment options according common use cases.
@ZycaR ZycaR requested a review from ImUrX as a code owner April 25, 2024 01:39
@ZycaR ZycaR marked this pull request as draft April 25, 2024 01:40
@ZRock35
Copy link
Contributor

ZRock35 commented Apr 25, 2024

Some observations:
The Lower Body 5 set has waist, when it should be assigned as chest for best tracking. Virtual waist kicks in, and sitting and laying down are far better in comparison to having it set as waist.
6 is the most commonly recommended set, and is not present in this, and waist is not the recommended assignment, hip is.
8 "enhanced set of core trackers" is not quite the right wording, since you skipped putting the "core" set it now doesn't have context.
10 is not "universal" nor would I say it's suitable for most users, it's kind of an advanced set, for dancers most often.
13 how it is pictured there doesn't make sense for VRChat, as VRChat doesn't use lower arm trackers. 13 tracker setup in VRChat would be adding the waist tracker, then either shoulders OR upper chest + neck tracker for additional torso stability.
20 is not good for VRChat at all and will cause major problems such as controllers not working. It is strictly for mocap/vtubing.
There are a lot more details, but figured I'd at least mention those things.

In my honest opinion, although I think this is neat and it's been suggested in the discord before, it would be better to have a slider that goes from 1 up to 20, that fills in at the proper points, as you slide it.

@sctanf
Copy link
Member

sctanf commented Apr 25, 2024

assuming at this point the user has connected all their possible trackers, you could use the number of trackers and extensions connected as a hint to what tracking assignment is recommended

@ZycaR
Copy link
Contributor Author

ZycaR commented Apr 25, 2024

@ZRock35 Thank you for your input, especially regarding my English, which ( as you probably noticed) is not my strong suit.

I had an idea to introduce these selectable options because first-timers are often confused about where to mount their trackers.
In this PR, I'll aim to update the options according to the official sets: x5, x6, x8, x10, x16, and all x20 trackers.

To have a slider instead of options is a great idea. One significant advantage is the better granularity of options; a slider saves screen space; and last but not least, we can cut some corners on translations.
I'll do my best with research (on Discord) to find recommended configurations for the slider and prepare something if it's still a requested feature.
@sctanf - ... or set the slider accordingly?

@ButterscotchV ButterscotchV added Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature labels Apr 25, 2024
@ZycaR
Copy link
Contributor Author

ZycaR commented Apr 29, 2024

Could you please take a look at the options section for the number of trackers? As English isn't my native language, I'm particularly interested in feedback on the options themselves and the wording from someone more proficient in language nuances.

Lower-Body Set - Set of trackers for lower body tracking
Core Set - Most commonly recommended set of trackers
Enhanced Core Set - Enhanced set of core trackers
Full Body Tracking (FBT) - Advanced set of trackers, for dancers
Complete Set - Complete set of all available trackers

image

@ZycaR ZycaR marked this pull request as ready for review April 29, 2024 21:28
@ZycaR ZycaR requested a review from Erimelowo as a code owner April 29, 2024 21:28
gui/src/components/commons/Radio.tsx Outdated Show resolved Hide resolved
gui/src/components/onboarding/BodyAssignment.tsx Outdated Show resolved Hide resolved
gui/src/components/onboarding/BodyAssignment.tsx Outdated Show resolved Hide resolved
gui/src/components/onboarding/BodyAssignment.tsx Outdated Show resolved Hide resolved
gui/src/components/onboarding/BodyAssignment.tsx Outdated Show resolved Hide resolved
gui/src/components/onboarding/BodyAssignment.tsx Outdated Show resolved Hide resolved
gui/public/i18n/en/translation.ftl Outdated Show resolved Hide resolved
@ZycaR ZycaR requested a review from ImUrX May 13, 2024 14:53
@ZycaR
Copy link
Contributor Author

ZycaR commented May 24, 2024

any luck this will be merged into the next release?

@ImUrX
Copy link
Member

ImUrX commented May 25, 2024

yeah dont worry about that, just that most maintainers are away :p

@ZRock35
Copy link
Contributor

ZRock35 commented May 25, 2024

A complete set assigned, of all 20 Slimes, will conflict with an active SteamVR headset, and should probably be blocked so it can't accidentally be done - it might work if it is strictly being used for VTubing or mocap with no HMD involved, but have a popup that gives a warning about that or make it have an option to use 19.

@Erimelowo
Copy link
Member

Erimelowo commented May 25, 2024

The server will prioritize head trackers with positional data (e.g. HMDs) so it’s not a problem. (Actually zrock pointed out that it’s currently bugged but that’s out of the scope of this PR anyways)

I’ll review eventually (was too busy with school before… in vacation now!), but it’ll definitely be in 0.13.0!

@ZRock35
Copy link
Contributor

ZRock35 commented May 25, 2024

Relevant Issue about the HMD+SlimeVR head tracker bug: #1040

Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens to hide the warnings. I'd move the warning above the buttons and add a scrollbar on the page.

slimevr_GqftJKvSPp

gui/public/i18n/en/translation.ftl Outdated Show resolved Hide resolved
@ZycaR
Copy link
Contributor Author

ZycaR commented Jun 10, 2024

This happens to hide the warnings. I'd move the warning above the buttons and add a scrollbar on the page.

slimevr_GqftJKvSPp

The latest commit should reflect your request. I was able to relocate the warning message and add a scrollbar without visual changes to the other onboarding pages.
Warnirng Scrollbar

@ZycaR ZycaR requested a review from Erimelowo June 10, 2024 11:28
@ImUrX ImUrX linked an issue Jun 14, 2024 that may be closed by this pull request
@ImUrX ImUrX requested a review from loucass003 June 14, 2024 14:35
@ImUrX
Copy link
Member

ImUrX commented Jun 17, 2024

can u please fix conflicts?

@loucass003 loucass003 merged commit d9da554 into SlimeVR:main Jun 17, 2024
12 checks passed
@ZycaR ZycaR deleted the gui-tracker-assignment-options branch June 17, 2024 20:08
@loucass003 loucass003 linked an issue Jun 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature
Projects
None yet
7 participants