Add a way to save serial logs as a file #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImUrX
added
Area: GUI
Erimelowo
requested changes
Jun 6, 2024
gui/public/i18n/en/translation.ftl
Outdated
| @@ -469,6 +469,8 @@ settings-serial-get_infos = Get Infos | |||
| settings-serial-serial_select = Select a serial port | |||
| settings-serial-auto_dropdown_item = Auto | |||
| settings-serial-get_wifi_scan = Get WiFi Scan | |||
| settings-serial-file_type = Serial log | |||
There was a problem hiding this comment.
Is this really correct? Why not "Text file" or "Plain text"?
…Server into save-serial-logs-button
Erimelowo
approved these changes
Jul 23, 2024
ButterscotchV
approved these changes
Jul 24, 2024
Co-authored-by: Butterscotch! <bscotchvanilla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a button that let's you save to a file the serial logs, it also does
GET INFOif it wasn't triggered already.